Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal]: Throw ObjectDisposedException when appropriate #10648

Open
MichalPavlik opened this issue Sep 11, 2024 · 0 comments
Open

[Proposal]: Throw ObjectDisposedException when appropriate #10648

MichalPavlik opened this issue Sep 11, 2024 · 0 comments
Labels
Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. internal-team-onboarding Priority:3 Work that is nice to have triaged

Comments

@MichalPavlik
Copy link
Member

Inspired by this comment. It looks like we are not using ObjectDisposedException when we should. This exception indicates exactly why the operation couldn't be completed and reduces confusion. We should throw this exception at least in public disposable types.
@hknielsen hknielsen mentioned this issue Sep 11, 2024
Closed
@AR-May AR-May added internal-team-onboarding Priority:3 Work that is nice to have Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. triaged labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. internal-team-onboarding Priority:3 Work that is nice to have triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichalPavlik @AR-May