Remove AIContent.ModelId, add StreamingChatCompletionUpdate.ModelId #5535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiriktsarpalis
added
the
* NO MERGE *
| /// Gets or sets the model ID used to generate the content. | ||
| /// </summary> | ||
| public string? ModelId { get; set; } | ||
|
|
||
| /// <summary>Gets or sets additional properties for the content.</summary> | ||
| public AdditionalPropertiesDictionary? AdditionalProperties { get; set; } |
There was a problem hiding this comment.
Unrelated to this change per se, but should we also consider scoping AdditionalProperties to the session rather than individual content values?
There was a problem hiding this comment.
I'm not following. AdditionalProperties on the content is a way of adding additional provider-specific metadata to each piece of content, for example image detail on an ImageContent.
eiriktsarpalis
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5529
This is a source and binary break. We should discuss when best to merge, and merge other similar breaks at the same time. We've had a few discussions about ctors to remove and things like that.
cc: @SteveSandersonMS, @eiriktsarpalis
Microsoft Reviewers: Open in CodeFlow