HybridCache stability and logging improvements #5467
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enforce payload quota - enforce key validity - add proper logging (infrastructure failure: needs attn)
- log deserialization failures - expose serialization failures - tests for serialization logging scenarios
|
Hey @mgravell, as FYI I have re-targeted this PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stability (i.e. when bad things happen, it should be as gentle as possible) and logging:
ILoggerlogging of significant eventsMaximumPayloadBytes, fixes HybridCache MaximumPayloadBytes not operating per documentation #5432MaximumKeyLength(do not use cache for invalid keys)Note: the
ILoggercode is glitching at the moment, meaning: it should be code-gen'd, but that step is failing; I have manually generated for now, while I investigate thisMicrosoft Reviewers: Open in CodeFlow