Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsmDiff: Do not show APIs with protected internal visibility #14579

Open
carlossanlop opened this issue Mar 12, 2024 · 1 comment
Open

AsmDiff: Do not show APIs with protected internal visibility #14579

carlossanlop opened this issue Mar 12, 2024 · 1 comment
Labels
area-Infrastructure-libraries Area maintained by .NET libraries team: APICompat, AsmDiff, GenAPI, GenFacades, PkgProj, etc

Comments

@carlossanlop
Copy link
Member

As seen here: dotnet/core#9220 (comment)

@Zastai
Copy link

Zastai commented Sep 11, 2024

Curious: why would protected internal not be considered public API just like plain protected would? It adds access from inside the assembly.

In the linked issue, was the intent to remove the constructor in question from the public API?
Then should it not be private protected instead? Plus, if the API diff is taking something from public or protected to internal or private protected, then that is an API break and should absolutely be in the diff.

What I would say is that for the purpose of an API diff protected and protected internal should probably be considered equivalent, and just rendered as protected. Adding/removing internal access to a protected member has no API impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure-libraries Area maintained by .NET libraries team: APICompat, AsmDiff, GenAPI, GenFacades, PkgProj, etc
Projects
None yet
Development

No branches or pull requests

2 participants