From 910572ebaab0c7f3fdec50838735e67ca728bf94 Mon Sep 17 00:00:00 2001 From: Max Hoffman Date: Mon, 16 Sep 2024 16:11:55 -0700 Subject: [PATCH] [stats] convert binary to string for stats bound rows --- sql/stats/iter.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sql/stats/iter.go b/sql/stats/iter.go index daa5695b65..44cc8c8d32 100644 --- a/sql/stats/iter.go +++ b/sql/stats/iter.go @@ -16,6 +16,7 @@ package stats import ( "fmt" + "github.com/dolthub/go-mysql-server/sql/types" "io" "strings" "time" @@ -134,12 +135,17 @@ func ParseRow(rowStr string, types []sql.Type) (sql.Row, error) { return row, nil } -func StringifyKey(r sql.Row, types []sql.Type) string { +func StringifyKey(r sql.Row, typs []sql.Type) string { b := strings.Builder{} sep := "" for i, v := range r { + typ := typs[i] + if _, ok := typ.(sql.StringType); ok { + typ = types.LongText + v, _, _ = typ.Convert(v) + } if v == nil { - v = types[i].Zero() + v = typ.Zero() } fmt.Fprintf(&b, "%s%v", sep, v) sep = ","