Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log queries in "error running query" WARN log message #8074

Open
fulghum opened this issue Jun 26, 2024 · 1 comment
Open

Log queries in "error running query" WARN log message #8074

fulghum opened this issue Jun 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@fulghum
Copy link
Contributor

fulghum commented Jun 26, 2024

Currently, Dolt sql-server logs include all the queries being executed only when logging is configured at the DEBUG level – queries are not included in the logs at the default logging level. This is important to keep the logs from growing too quickly, but can make it difficult for customers to find a query that isn't executing in Dolt correctly. When we log an "error running query" warning, if we included the query (or the first ~150 characters or so) it would make it easier for customers to identify queries that aren't executing correctly and either report them (if it's a MySQL compatibility issue) or fix them (if it's an issue with their application forming bad queries).

@timsehn
Copy link
Sponsor Contributor

timsehn commented Jun 26, 2024

There's privacy/security concerns about putting raw SQL queries in the logs by default but we could certainly make this a log level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants