-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include doesn't create backlinks any more since Hogfather #251
Comments
Is it possible that the included page is not public? The |
The included pages are public, they have no special access restrictions.
|
Then this is clearly a bug that I cannot easily explain. I will try to find some time to take a closer look. Did this work before upgrading to Hogfather in an otherwise unchanged wiki? |
Yes, before Hogfather it definetly worked. |
I think I understand at least why it does not work, I do not understand why it did work in the past. The reason is that at some point I thought it was a good idea to filter out pages the user cannot access rather early. This has the consequence that the include plugin does not even create a Anyways, the correct fix for this is to always generate Just for reference, this issue is most likely also the reason for broken move plugin support, see #259. |
Thanks for your feedback and looking into this! :) |
@michitux I have not yet looked into this, but is this something only in this plugin, or are there possible changes in DokuWiki needed? If yes, it is good to open an issue at DokuWiki repository as well and get it included in the next release. |
I haven't followed the latest changes in DokuWiki that closely, but from my analysis I think this is something in this plugin, basically my comment above explains what needs to be done. It's just not a one-line-fix but instead a rather fundamental change where ACL checks happen that also affects caching (though cache handling should also be changed, anyway, as the current state is rather fragile). I have no idea when I'll find the time to do this, if you have some time and want to look into this, I would also be happy to explain my ideas (or how this plugin works in general) in more detail. |
It is interesting, but at the moment I have quite some other thing on my wish list, and as this one will take some effort, I prefer not to dive in it at the moment. |
thanks a lot for looking into it @michitux and @Klap-in. However your assessments leaves me slightly unsure about the future of the this plugin. I see that #274 has just been solved, but other issues might pop up at latest with the next DW release. Our department Wiki relies heavily on page includes. The problem with the renaming (#276) has just come up recently. Basically I think that what the include plugins offers should be a core functionality of DW |
If you rely on this plugin in your company/institution, I would suggest paying for commercial support instead of relying on volunteers maintaining this plugin in their free time. Have a look at https://www.wikimatrix.org/consultants/dokuwiki/ for a list of DokuWiki consultants if you are looking for a suitable consultant (note that I'm not affiliated with any of them). |
Whenever you will find time to look into this: Your efforts are appreciated! |
Dokuwiki: Release rc-2020-06-09 "Hogfather" RC3
Include plugin: Installed version: 2020-04-16
Previously, includes via page or section include created a backlink.
Since the upgrade to Hogfather, no backlinks are visible any more.
Exception: At least pages that have been edited recently do show backlinks to included pages.
Example:
The text was updated successfully, but these errors were encountered: