Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shopify_dlt pipeline: Missing dependency 'ShopifyAPI' in requirements.txt #157

Closed
rahuljo opened this issue May 30, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@rahuljo
Copy link

rahuljo commented May 30, 2023

Pipeline name
shopify_dlt

Describe the bug
After I initiate a shopify project using dlt init shopify_dlt bigquery, the requirements.txt file only contains:

dlt[bigquery]>=0.2.8

So, after running python shopify_dlt_pipeline.py, I get the error:

Traceback (most recent call last):
  File "shopify_dlt_pipeline.py", line 6, in <module>
    from shopify_dlt import shopify_source
  File "C:\Users\rahul\OneDrive\Desktop\Work\shopify_demo\issue\shopify_dlt\__init__.py", line 6, in <module>
    import shopify
ModuleNotFoundError: No module named 'shopify'

I fix this by doing pip install ShopifyAPI

Expected behavior
Dependency ShopifyAPI should be included in the automatically generated requirements.txt

Running environment

  • OS: Windows
  • dlt Version: 0.2.9
@rahuljo rahuljo added the bug Something isn't working label May 30, 2023
@rudolfix rudolfix assigned sh-rp and unassigned rudolfix May 30, 2023
rudolfix added a commit that referenced this issue Jun 6, 2023
closes #156
closes #155

includes a few goodies as a result of #155

each destination can have a separate naming convention
name shortening works ie. for postgres
naming convention can be configured
A few other improvements: how to query for data with sql_client

forward unknown calls to native connection (ie. to use duckdb conn methods seamlessly)
exposes df method on cursor that returns data as dataframe (natively if possible)
@rudolfix
Copy link
Contributor

fixed in #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants