Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly validate IIIF through the API #103

Open
JackLewis-digirati opened this issue Oct 21, 2024 · 1 comment
Open

Correctly validate IIIF through the API #103

JackLewis-digirati opened this issue Oct 21, 2024 · 1 comment

Comments

@JackLewis-digirati
Copy link
Collaborator

JackLewis-digirati commented Oct 21, 2024

Currently, the API attempts to "validate" IIIF by serializing and deserializing a collection, which can help strip out unwanted fields. However, this process is slow and not truly validating the IIIF as this can lead to collections being served that aren't valid - ie missing "id" or "@context". I think for now we should ensure that all collections and manifests saved to s3 always have id + context

This ticket is to improve this behaviour

@sarahos
Copy link
Collaborator

sarahos commented Oct 24, 2024

Currently, the iiif-net package is used to validate IIIF collections through serializaion.

That package isn't a iiif validator. There'll likely be IIIF shapes that it can't handle and deserialisation isn't complete

This ticket is to create a proper validator for IIIF collections

the pypi package has a json-schema, could we use that? Or add validation to iiif-net (https://github.com/IIIF/presentation-validator/blob/main/schema/iiif_3_0.json)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants