Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with long URLs #71

Open
dtonne opened this issue Dec 7, 2017 · 1 comment
Open

Problem with long URLs #71

dtonne opened this issue Dec 7, 2017 · 1 comment
Labels

Comments

@dtonne
Copy link

dtonne commented Dec 7, 2017

The table annotation_target restricts targetiri and sourceiri to 100 characters. Creating annotations with longer "source" fields does not fail according to the HTTP responses, the database however logs ERROR: value too long for type character varying(100). Fetching the annotation remains possible, search or stats by target fail.

Is this restriction due to a specific purpose or is it possible to allow longer entries? And does somebody have an overview where this issue might also apply?

@danielgrant
Copy link
Contributor

Hi @dtonne,

A length of 100 was just an arbitrary choice to be honest, and perhaps a bit short sighted. As you've observed, this won't affect the saving and fetching of annotations, but it will affect searching, statistics, etc as these features depend on being able to successfully break up a saved annotation into its constituent parts to persist them in the database.

The fix for this is as simple as modifying the targetiri and sourceiri column lengths in the database to a more suitable value. I'll keep this issue open to have this applied to the database scripts, in the meantime there's nothing preventing you from modifying the column length on your own installation if you require a quicker resolution.

Cheers,
Daniel.

@danielgrant danielgrant added the bug label Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants