Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional postgres permissions #108

Open
vrish88 opened this issue Dec 2, 2020 · 1 comment
Open

Optional postgres permissions #108

vrish88 opened this issue Dec 2, 2020 · 1 comment

Comments

@vrish88
Copy link

vrish88 commented Dec 2, 2020

Hello there!

Tonight I was working on getting elucidate deployed on heroku. One of the snags I ran into was the use of db permissions. On the hobbyist plan (aka the free one), they don't allow you to modify any roles or permissions. To get around this, I commented out all liquidbase sql statements that had anything to do with permission (ALTER FUNCTION ... OWNER, GRANT EXECUTE..., REVOKE ALL, etc).

Now these were obviously here for a good reason (ie a real production environment or something reasonable like that) however that reason didn't apply to my particular deployment configuration (one where the permissions are managed by the host).

Would you be open to a PR making the postgres permissions optional? Some solution which would allow elucidate to be deployed with/without postgres permissions configured?

One possible solution I came across was to use liquidbase labels to accomplish this. Thoughts?

Thank you for work of implementing the w3c annotation server! I was afraid I'd have to make my own implementation but then I fortuitously came across all the work done here!

@danielgrant
Copy link
Contributor

Hi @vrish88,

The point you've raised here is valid and indeed it's probably a bit presumptuous of us to assume that everyone would want to adopt the same permissions model in their PostgreSQL database as we have when we originally put this together.

The quickest way to turn this around would probably be to open a PR against this repository with the changes you'd like to see. Otherwise it might be some time before myself or another maintainer would be able to pick it up, if at all.

Cheers,
Daniel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants