Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with ldc 1.33.0 #2716

Closed
ptrcnull opened this issue Nov 18, 2023 · 1 comment
Closed

Build fails with ldc 1.33.0 #2716

ptrcnull opened this issue Nov 18, 2023 · 1 comment

Comments

@ptrcnull
Copy link

System information

  • dub version: 1.34.0
  • OS Platform and distribution: Alpine Linux edge
  • compiler version: 1.33.0

Bug Description

A lot of deprecation warnings turned into errors when trying to build latest dub stable with latest ldc:

source/dub/dependency.d:917:32: error: scope variable 'this' assigned to non-scope parameter 'oth' calling 'opEquals' [-Werror=deprecated]
  917 |                 if (m_versA == m_versB)
      |                                ^
source/dub/dependency.d:920:44: error: scope variable 'this' assigned to non-scope parameter 'a' calling 'doCmp' [-Werror=deprecated]
  920 |                 return doCmp(m_inclusiveA, m_versA, v) &&
      |                                            ^
source/dub/dependency.d:921:48: error: scope variable 'this' assigned to non-scope parameter 'b' calling 'doCmp' [-Werror=deprecated]
  921 |                         doCmp(m_inclusiveB, v, m_versB);
      |                                                ^
source/dub/dependency.d:939:40: error: scope variable 'this' assigned to non-scope parameter 'oth' calling 'opEquals' [-Werror=deprecated]
  939 |                 return this.m_versA == this.m_versB;
      |                                        ^

How to reproduce?

Expected Behavior

dub builds correctly despite the deprecation warnings and doesn't block downstream usage by enforcing every warning to be a fatal error

Logs

https://dev.alpinelinux.org/~ptrc/dub-1.34.0-r0.log

@ptrcnull
Copy link
Author

nevermind, apparently gdc was being installed and picked by accident, closing in favour of #2577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant