Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot 4.3 Resource icons! #2355

Open
firedfromlife opened this issue Jul 30, 2024 · 4 comments
Open

Godot 4.3 Resource icons! #2355

firedfromlife opened this issue Jul 30, 2024 · 4 comments
Labels
Approved This can be added, but is not on any roadmap yet UI/UX ✏

Comments

@firedfromlife
Copy link
Contributor

firedfromlife commented Jul 30, 2024

Is your feature request related to a problem? Please describe.
Finally, as of Godot 4.3 custom resources can have their own icons! Timelines and Characters should absolutely support this

Describe the solution you'd like
Add the new @ icon annotation to those classes.

Additional context
I intend to submit a PR for this, though it seems @ icon annotation doesn't work correctly for custom extensions?

@Jowan-Spooner Jowan-Spooner added UI/UX ✏ Approved This can be added, but is not on any roadmap yet labels Jul 30, 2024
@firedfromlife
Copy link
Contributor Author

I also realized, there currently isn't a custom icon for the timelines. It just uses the three line hamburger menu icon. I came up with one real quick, any thoughts?

I fear it may not read at lower resolutions so I may change it.

image

@Jowan-Spooner
Copy link
Collaborator

Yeah, I think this won't work as an icon. Feel free to try out some more though! We certainly need an svg. You can find the svgs of all the godot icons here, in case it helps 😋: https://github.com/godotengine/godot/tree/master/editor/icons

I think timeline is a hard concept to put into a small icon, so I assume we can't get much better then what we have right now, but maybe there is a way to make it NOT look like a hamburger menu :)?
Good luck, I'll test the sidebar PR tomorrow, for now I'm of to bed...

@firedfromlife
Copy link
Contributor Author

A couple other options:

  • Simple
    • -Asset 1
  • More speech bubble like
    • -Asset 2

Am done for today, but let me know.

@firedfromlife
Copy link
Contributor Author

I filed an issue with with Godot engine, and the issue has now been confirmed in 4.3 rc1. Custom icons for resources do not work with custom file extensions at the moment... At least in the file system. Hopefully will get fixed prior to 4.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved This can be added, but is not on any roadmap yet UI/UX ✏
Projects
None yet
Development

No branches or pull requests

2 participants