Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fixed time pause characters #2329

Open
juliohq opened this issue Jul 4, 2024 · 1 comment
Open

Custom fixed time pause characters #2329

juliohq opened this issue Jul 4, 2024 · 1 comment

Comments

@juliohq
Copy link
Contributor

juliohq commented Jul 4, 2024

Is your feature request related to a problem? Please describe.
Writing [pause=1.0] in your timelines is a bit too long for a simple feature, especially if your pauses have mostly the same length.

Describe the solution you'd like
I believe adding a special character like @, ~ or even * in the middle of your timelines might be a good idea to speed things up a bit. Preferably, the fixed time pause character could be configurable so users might choose what special character to use and how long each one should be.

Describe alternatives you've considered
N/A

Additional context
I've written some logic that worked fine for me in the res://addons/dialogic/Modules/Text/subsystem_text.gd script:

func parse_text_effects(text:String) -> String:
	...
	# Parse fixed pause asterisks
	var last_index = text.find("*")

	while last_index != -1:
		text = text.substr(0, last_index) + text.substr(last_index + 1)
		parsed_text_effect_info.append({
			'index': last_index,
			'execution_info': {
				'callable': effect_pause,
			},
			'value': "0.1"
		})
		last_index = text.find("*", last_index)
	...

This is just a draft feature and could evolve to something better than it looks like right now. What do you think about it?

@Jowan-Spooner
Copy link
Collaborator

Hey @juliohq this is kindof what auto-pauses already do, with the exception that they do not remove the symbol. But this could be implemented as a custom text modifier in an extension module pretty easily. I'm not sure it needs to be in the core, but I'm open to be convinced otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants