Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character portrait disappears until another character talks if I spam skip #9

Open
AdamKormos opened this issue Dec 26, 2022 · 1 comment

Comments

@AdamKormos
Copy link

AdamKormos commented Dec 26, 2022

The problem

We have a long dialogue in our game and I was experimenting with something when I realized if I keep skipping the dialogue too quickly, the character portrait disappears until another person comes up to talk.

Describe the bug
We're using the Default animation setting on every Character Leave and Join command, without waiting for either. I'm suspecting that could be the issue, and the console also prints "No animation found with name: [Default]" whenever the portrait doesn't come up. It also feels like this only occurs whenever I skip so that the displayed text ends, and doesn't start yet/is about to start showing up.
I noticed the previous actor's portrait is in the middle of fading out when the other comes up while I'm skipping quickly, that's also a potential culprit.

To Reproduce
Create a dialogue where you have two actors, with only either being visible during any of the lines.
Skip rapidly and stop after x amount of texts got displayed.

Expected behavior
The current actor's portrait doesn't show.

Screenshots
This is how a character transition is set up for us, if that helps at all: image

System (please complete the following information):

  • OS: Windows
  • Godot Version: 3.5.1
  • Dialogic Version: 1.4.2

Solutions

Workaround

In DialogicAnimaResources.gd's get_animation_script function, I tried to set the animation from [Default] to the one that was printed every other time (fade_in_up.gd or something similar), but that didn't work.

Possible fixes

The animation tweens could be having some interference issue, I didn't dig too deep into the plugin code, but that's my only assumption.

@Jowan-Spooner Jowan-Spooner transferred this issue from dialogic-godot/dialogic Apr 10, 2024
@zaknafean
Copy link
Collaborator

This is likely linked to #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants