Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom theme on character messes with theme preview #4

Open
2 of 3 tasks
Jowan-Spooner opened this issue Mar 28, 2022 · 2 comments
Open
2 of 3 tasks

Custom theme on character messes with theme preview #4

Jowan-Spooner opened this issue Mar 28, 2022 · 2 comments

Comments

@Jowan-Spooner
Copy link
Collaborator

Jowan-Spooner commented Mar 28, 2022

The problem

This behaviour is somewhat expected but far from what one would expect.

If you select a character for the theme preview that has a custom theme set, it won't actually display the theme you are editing but the custom theme of the character.

Because the character is selected at random by default, this can be VERY VERY confusing as described here #850.

Solutions

  • Characters with custom themes should only be suggested/possible if it's their theme that is edited.
  • Additionally the design of the character selection box should make clear that it is a setting
  • The character should either not be random by default or remember what character you set (possible for each theme)
@coppolaemilio
Copy link
Contributor

Made it easier to understand what the character picker is by adding proper styling and changing its position. dialogic-godot/dialogic@b35e439

The fix for the other two tasks are coming whenever I can continue.

@coppolaemilio
Copy link
Contributor

Fixed the first one Characters with custom themes should only be suggested/possible if it's their theme that is edited.
Only the last one needs to be fixed, but I might not include it into Dialogic 1.4.2 since we are already going too over the scope of the update

@Jowan-Spooner Jowan-Spooner transferred this issue from dialogic-godot/dialogic Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants