New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

struct literal of URL very easy to misuse #19

Open

John-Colvin opened this issue Dec 16, 2019 · 1 comment

John-Colvin commented Dec 16, 2019

e.g. URL("http://www.google.com") compiles but very much does not do what it looks like.

The text was updated successfully, but these errors were encountered:

FigmentEngine commented Jun 30, 2020 •

edited

Loading

missing final slash after host causes problems:
URL url;

`

if (tryParseURL("example.com/?" ~ "country=france", url)) {
	string country = url.queryParams["country"].front;
	writefln("Url %s QS %s", url, country);
}`

works, but this won't as it won't find the query string due to the lack of the forward slash
`

if (tryParseURL("example.com?" ~ "country=france", url)) {
	string country = url.queryParams["country"].front;
	writefln("Url %s QS %s", url, country);
}`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment