Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external_link() hidden text is not hidden #47

Closed
cjrace opened this issue Sep 11, 2024 · 1 comment · Fixed by #48
Closed

external_link() hidden text is not hidden #47

cjrace opened this issue Sep 11, 2024 · 1 comment · Fixed by #48
Assignees
Labels
bug Something isn't working

Comments

@cjrace
Copy link
Contributor

cjrace commented Sep 11, 2024

Describe the bug

When using the add_warning = FALSE argument there should be a hidden message saying "This link opens in a new tab". However, I overlooked the need for CSS for the custom class, and the text is rendering for all users.

How to reproduce

Steps to reproduce the behaviour:

  1. Clone this repo (or use another R Shiny app)
  2. Add an external_link() with add_warning = FALSE
  3. Run the app
  4. See the hidden text still appears visually

Expected behaviour

Hidden text should not show.

Screenshots

image

Code for this tab is:

      ## Example text panel ---------------------------------------------------
      shiny::tabPanel(
        value = "text_example",
        "Text example",
        shiny::tags$h2("Hey, here's a heading"),
        shiny::tags$p(
          "Hey ",
          external_link(
            "https://shiny.posit.co/",
            "R Shiny"
            ),
          " is so great we should show it off more."
        ),
        shiny::tags$p(
          "Sometimes you just want to be in a cave without distractions",
          " when writing code in ",
          external_link(
            "https://shiny.posit.co/",
            "R Shiny",
            add_warning = FALSE
          ),
          "."
        )
      )

Additional context

Nothing further to add.

@cjrace cjrace added the bug Something isn't working label Sep 11, 2024
@cjrace cjrace self-assigned this Sep 11, 2024
@cjrace
Copy link
Contributor Author

cjrace commented Sep 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant