Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classifier contains outdated CVCL ontology tree #278

Open
dmalzl opened this issue Nov 29, 2023 · 0 comments
Open

Classifier contains outdated CVCL ontology tree #278

dmalzl opened this issue Nov 29, 2023 · 0 comments

Comments

@dmalzl
Copy link

dmalzl commented Nov 29, 2023

When installing the pipeline it starts with downloading and preparing the used ontologies. This process fetches the newest versions of them which work perfectly fine. However, when running the pipeline like this it frequently raises KeyErrors during the sample type prediction stage. Digging a bit into the code, this is a result of the provided classifier model containing it's own, and possibly outdated, copy of a CVCL ontology tree which may not contain a given key from the newer version and thus fails to retrieve the corresponding terms when trying to hash it. This can be solved however by loading the CVCL ontology and replacing the classifiers copy in the map_sra_to_ontology/run_sample_type_prediction.py like so:

model.cvcl_og = load_ontology("/path/to/cvcl_obo")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant