Python 3.12 - AttributeError: module 'pathlib' has no attribute '_Flavour' #430

briantist · 2023-08-13T00:13:17Z

Python 3.12 is now released, but it does not work due to pathlib changes:

/opt/hostedtoolcache/Python/3.12.0-rc.1/x64/lib/python3.12/site-packages/artifactory.py:426: in
class _ArtifactoryFlavour(pathlib._Flavour):
E AttributeError: module 'pathlib' has no attribute '_Flavour'

I figured I'd add 3.12 into the test matrix on my project which relies on this library, and that's how I found this issue:

https://github.com/briantist/galactory/actions/runs/5844080610/job/15846784439?pr=80#step:5:40

Not any kind of pressing issue yet.

allburov · 2023-08-14T10:32:10Z

Thank you for the feedback!
If anyone has idea how to fix this - feel free to create a PR

brot · 2023-09-04T15:38:22Z

Python 3.12 will add support for subclassing pathlib.PurePath and Path

See also the cpython github issue: python/cpython#31691

barneygale · 2023-10-03T19:56:18Z

I'm hoping to add a pathlib.PathBase class for Python 3.13. Once it's in the codebase, I'll publish a backport package on PyPI for Python <3.13. dohq-artifactory could subclass PathBase to implement ArtifactoryPath.

CPython issue: python/cpython#110109

ktdreyer · 2023-12-08T18:43:53Z

@barneygale Thank you for your work in core for this. It will be great to simplify the dohq-artifactory codebase.

Do you suggest any other solution for py312 in the meantime? Should we try subclassing something from py312's pathlib prior to pathlib.PathBase being available?

I'm running Python 3.12 on my laptop (Fedora 39), and I've hacked artifactory.py so that it doesn't crash. I can list directories and download and upload basic files. My changes are in my py312 branch, but I'm not sure they're acceptable for a PR here.

barneygale · 2023-12-08T18:59:40Z

I'd recommend that you wait if you can - I'm expecting to publish a PyPI package with the base classes some time this month.

barneygale · 2023-12-08T19:01:31Z

Preview: https://github.com/python/cpython/blob/33f9af159adce62008934a6d304511401d650a8d/Lib/pathlib/_abc.py#L535

barneygale · 2023-12-23T03:17:35Z

Git project: https://github.com/barneygale/pathlib_abc

Currently it only supports Python 3.11+, but I should have it working for 3.8+ within a couple of weeks, at which point I'll publish a PyPI package.

barneygale · 2023-12-27T17:18:06Z

First PyPI release: https://pypi.org/project/pathlib-abc/0.1.0/

FHTMitchell · 2024-01-24T17:37:17Z

I'm seeing the same issue in py3.11 now

dkmiller · 2024-02-05T18:08:52Z

Hey everyone - any progress here?

zhan9san · 2024-02-06T07:05:31Z

Hey guys,

Thanks for reporting this issue. I'd like to work on it.

barneygale · 2024-02-24T21:56:18Z

IMO the best way to fix this is to add a dependency on pathlib-abc, and make ArtifactoryPath inherit from PathBase.

@zhan9san is that what you're pursuing? If not I might have a crack at it.

lukezhangtyler · 2024-03-08T18:39:47Z

I hope this will be remediated soon.

okainov · 2024-03-19T12:56:08Z

@zhan9san @beliaev-maksim hi folks, any update on this issue? Given Python 3.12 is fully released and supported, it would be very appreciated that Artifactory library supports it, it's the only item blocking our migration to 3.12 now...

allburov · 2024-03-20T05:04:53Z

We are looking for a volunteer!

andrewsiemer · 2024-04-10T01:23:28Z

+1 this is blocking migrating to python 3.12

hacklint · 2024-05-03T09:11:46Z

Any hope of this being resolved before release of python 3.13?

barneygale · 2024-06-07T23:02:10Z

FWIW I've started a new pathlib-artifactory package building on the semi-official pathlib-abc package. It doesn't rely on hacking into the pathlib internals (unlike dohq-artifactory) so it should be on surer footing. But it's missing tons of features and it's certainly not a drop-in replacement for dohq-artifactory yet. Issues and PRs very welcome.

mshafer-NI · 2024-07-03T22:03:36Z

@allburov, @barneygale, I took a swing at using the pathlib-abc, but it's erroring on

    from artifactory import ArtifactoryPath
.tox/py39/lib/python3.9/site-packages/artifactory.py:1490: in <module>
    class ArtifactoryPath(pathlib.Path, PureArtifactoryPath):
/pyenv/versions/3.9.18/lib/python3.9/abc.py:106: in __new__
    cls = super().__new__(mcls, name, bases, namespace, **kwargs)
E   TypeError: multiple bases have instance lay-out conflict

You can see my progress here: mshafer-NI#1

LeiYangGH · 2024-09-10T09:10:56Z

any walkaround?

seltsa · 2024-09-10T15:44:47Z

Any updates for Fedora39 ? Hit the same issue

LeiYangGH · 2024-09-12T03:06:38Z

FWIW I've started a new pathlib-artifactory package building on the semi-official pathlib-abc package. It doesn't rely on hacking into the pathlib internals (unlike dohq-artifactory) so it should be on surer footing. But it's missing tons of features and it's certainly not a drop-in replacement for dohq-artifactory yet. Issues and PRs very welcome.

thanks and could you add a little document on the readme, for example, why create the project, are the usage compatible with devopshq artifactory?

FrogWithASock · 2024-09-18T11:42:00Z

Any updates? Is this project dead? There was no commit to main for 7 months now

allburov · 2024-09-18T11:45:19Z

Is this project dead?

Not dead, but yeah, no active maintainer here :(
We're happy to review any PR for the issue and any help! 🙏

I don't work with artifactory anymore, so can not even test it :(

oscarm3l1n · 2024-09-24T12:13:13Z

@barneygale Thank you for your work in core for this. It will be great to simplify the dohq-artifactory codebase.

Do you suggest any other solution for py312 in the meantime? Should we try subclassing something from py312's pathlib prior to pathlib.PathBase being available?

I'm running Python 3.12 on my laptop (Fedora 39), and I've hacked artifactory.py so that it doesn't crash. I can list directories and download and upload basic files. My changes are in my py312 branch, but I'm not sure they're acceptable for a PR here.

Tested this locally, works like a charm!

oscarm3l1n · 2024-09-24T12:14:29Z

@barneygale Thank you for your work in core for this. It will be great to simplify the dohq-artifactory codebase.

Do you suggest any other solution for py312 in the meantime? Should we try subclassing something from py312's pathlib prior to pathlib.PathBase being available?

I'm running Python 3.12 on my laptop (Fedora 39), and I've hacked artifactory.py so that it doesn't crash. I can list directories and download and upload basic files. My changes are in my py312 branch, but I'm not sure they're acceptable for a PR here.

@ktdreyer
Since it's been almost a year. Have you worked around this issue somehow? (sounded on your implementation that it was more of a hack)

RoccoMatano · 2024-10-08T06:30:14Z

I use a little application that depends on artifactory and I want to run it with current python versions (i.e. 3.13). I don't know anything about the internals of artifactory, but I managed to patch it in such a way, that it fullfills my needs. I have no idea whether this works for all use cases.
For what it's worth, here's the diff:

--- C:\prj\progs\py313\Lib\site-packages\artifactory.0.10.1.py	2024-10-08 08:10:50.000000000 +0200
+++ C:\prj\progs\py313\Lib\site-packages\artifactory.py	2024-10-08 08:16:13.000000000 +0200
@@ -419,13 +419,13 @@
         quoted_path = requests.utils.quote(url.partition(parsed_url.host)[2])
         quoted_url = f"{parsed_url.scheme}://{parsed_url.host}{quoted_path}"
 
     return quoted_url
 
 
-class _ArtifactoryFlavour(pathlib._Flavour):
+class _ArtifactoryFlavour:
     """
     Implements Artifactory-specific pure path manipulations.
     I.e. what is 'drive', 'root' and 'path' and how to split full path into
     components.
     See 'pathlib' documentation for explanation how those are used.
 
@@ -437,13 +437,12 @@
     path: relative artifact path within the repository
     """
 
     sep = "/"
     altsep = "/"
     has_drv = True
-    pathmod = pathlib.posixpath
     is_supported = True
 
     def _get_base_url(self, url):
         return get_global_base_url(url)
 
     def compile_pattern(self, pattern):
@@ -1498,25 +1497,33 @@
     """
 
     if sys.version_info.major == 3 and sys.version_info.minor >= 10:
         # see changes in pathlib.Path, slots are no more applied
         # https://github.com/python/cpython/blob/ce121fd8755d4db9511ce4aab39d0577165e118e/Lib/pathlib.py#L952
         _accessor = _artifactory_accessor
+        parser = _ArtifactoryFlavour()
     else:
         # in 3.9 and below Pathlib limits what members can be present in 'Path' class
         __slots__ = ("auth", "verify", "cert", "session", "timeout")
+
+    def __init__(self, *args, **kwargs):
+        # supplying keyword arguments to pathlib.PurePath is deprecated
+        return super().__init__(*args)
 
     def __new__(cls, *args, **kwargs):
         """
         pathlib.Path overrides __new__ in order to create objects
         of different classes based on platform. This magic prevents
         us from adding an 'auth' argument to the constructor.
         So we have to first construct ArtifactoryPath by Pathlib and
         only then add auth information.
         """
         obj = pathlib.Path.__new__(cls, *args, **kwargs)
+        if sys.version_info.major == 3 and sys.version_info.minor >= 12:
+            # supplying keyword arguments to pathlib.PurePath is deprecated
+            obj.__init__(*args)
 
         cfg_entry = get_global_config_entry(obj.drive)
 
         # Auth section
         apikey = kwargs.get("apikey")
         token = kwargs.get("token")

hacklint · 2024-10-11T13:22:42Z

I use a little application that depends on artifactory and I want to run it with current python versions (i.e. 3.13). I don't know anything about the internals of artifactory, but I managed to patch it in such a way, that it fullfills my needs. I have no idea whether this works for all use cases. For what it's worth, here's the diff:

--- C:\prj\progs\py313\Lib\site-packages\artifactory.0.10.1.py	2024-10-08 08:10:50.000000000 +0200
+++ C:\prj\progs\py313\Lib\site-packages\artifactory.py	2024-10-08 08:16:13.000000000 +0200
@@ -419,13 +419,13 @@
         quoted_path = requests.utils.quote(url.partition(parsed_url.host)[2])
         quoted_url = f"{parsed_url.scheme}://{parsed_url.host}{quoted_path}"
 
     return quoted_url
 
 
-class _ArtifactoryFlavour(pathlib._Flavour):
+class _ArtifactoryFlavour:
     """
     Implements Artifactory-specific pure path manipulations.
     I.e. what is 'drive', 'root' and 'path' and how to split full path into
     components.
     See 'pathlib' documentation for explanation how those are used.
 
@@ -437,13 +437,12 @@
     path: relative artifact path within the repository
     """
 
     sep = "/"
     altsep = "/"
     has_drv = True
-    pathmod = pathlib.posixpath
     is_supported = True
 
     def _get_base_url(self, url):
         return get_global_base_url(url)
 
     def compile_pattern(self, pattern):
@@ -1498,25 +1497,33 @@
     """
 
     if sys.version_info.major == 3 and sys.version_info.minor >= 10:
         # see changes in pathlib.Path, slots are no more applied
         # https://github.com/python/cpython/blob/ce121fd8755d4db9511ce4aab39d0577165e118e/Lib/pathlib.py#L952
         _accessor = _artifactory_accessor
+        parser = _ArtifactoryFlavour()
     else:
         # in 3.9 and below Pathlib limits what members can be present in 'Path' class
         __slots__ = ("auth", "verify", "cert", "session", "timeout")
+
+    def __init__(self, *args, **kwargs):
+        # supplying keyword arguments to pathlib.PurePath is deprecated
+        return super().__init__(*args)
 
     def __new__(cls, *args, **kwargs):
         """
         pathlib.Path overrides __new__ in order to create objects
         of different classes based on platform. This magic prevents
         us from adding an 'auth' argument to the constructor.
         So we have to first construct ArtifactoryPath by Pathlib and
         only then add auth information.
         """
         obj = pathlib.Path.__new__(cls, *args, **kwargs)
+        if sys.version_info.major == 3 and sys.version_info.minor >= 12:
+            # supplying keyword arguments to pathlib.PurePath is deprecated
+            obj.__init__(*args)
 
         cfg_entry = get_global_config_entry(obj.drive)
 
         # Auth section
         apikey = kwargs.get("apikey")
         token = kwargs.get("token")

Tried this locally, worked fine for what I tested (read-only from Artifactory, no writes tested)

LeiYangGH · 2024-10-11T23:49:56Z

I use a little application that depends on artifactory and I want to run it with current python versions (i.e. 3.13). I don't know anything about the internals of artifactory, but I managed to patch it in such a way, that it fullfills my needs. I have no idea whether this works for all use cases. For what it's worth, here's the diff:

--- C:\prj\progs\py313\Lib\site-packages\artifactory.0.10.1.py	2024-10-08 08:10:50.000000000 +0200
+++ C:\prj\progs\py313\Lib\site-packages\artifactory.py	2024-10-08 08:16:13.000000000 +0200
@@ -419,13 +419,13 @@
         quoted_path = requests.utils.quote(url.partition(parsed_url.host)[2])
         quoted_url = f"{parsed_url.scheme}://{parsed_url.host}{quoted_path}"
 
     return quoted_url
 
 
-class _ArtifactoryFlavour(pathlib._Flavour):
+class _ArtifactoryFlavour:
     """
     Implements Artifactory-specific pure path manipulations.
     I.e. what is 'drive', 'root' and 'path' and how to split full path into
     components.
     See 'pathlib' documentation for explanation how those are used.
 
@@ -437,13 +437,12 @@
     path: relative artifact path within the repository
     """
 
     sep = "/"
     altsep = "/"
     has_drv = True
-    pathmod = pathlib.posixpath
     is_supported = True
 
     def _get_base_url(self, url):
         return get_global_base_url(url)
 
     def compile_pattern(self, pattern):
@@ -1498,25 +1497,33 @@
     """
 
     if sys.version_info.major == 3 and sys.version_info.minor >= 10:
         # see changes in pathlib.Path, slots are no more applied
         # https://github.com/python/cpython/blob/ce121fd8755d4db9511ce4aab39d0577165e118e/Lib/pathlib.py#L952
         _accessor = _artifactory_accessor
+        parser = _ArtifactoryFlavour()
     else:
         # in 3.9 and below Pathlib limits what members can be present in 'Path' class
         __slots__ = ("auth", "verify", "cert", "session", "timeout")
+
+    def __init__(self, *args, **kwargs):
+        # supplying keyword arguments to pathlib.PurePath is deprecated
+        return super().__init__(*args)
 
     def __new__(cls, *args, **kwargs):
         """
         pathlib.Path overrides __new__ in order to create objects
         of different classes based on platform. This magic prevents
         us from adding an 'auth' argument to the constructor.
         So we have to first construct ArtifactoryPath by Pathlib and
         only then add auth information.
         """
         obj = pathlib.Path.__new__(cls, *args, **kwargs)
+        if sys.version_info.major == 3 and sys.version_info.minor >= 12:
+            # supplying keyword arguments to pathlib.PurePath is deprecated
+            obj.__init__(*args)
 
         cfg_entry = get_global_config_entry(obj.drive)
 
         # Auth section
         apikey = kwargs.get("apikey")
         token = kwargs.get("token")

Tried this locally, worked fine for what I tested (read-only from Artifactory, no writes tested)

how to apply this patch after installing the official module?
it would be great if we can copy the patch to our project source folder which then 'monkey patch' the installed official module. is it possible?

allburov · 2024-10-14T09:58:50Z

patching is not the way to go, we should add it as built-in fix (if it works for all cases)

Let's not discuss patching here, I'll mark the comment as Off Topic in the future

briantist mentioned this issue Aug 13, 2023

Add Python 3.12 to test matrix briantist/galactory#80

Draft

allburov added the enhancement Feature request to extend functionality label Aug 14, 2023

hagenw mentioned this issue Oct 10, 2023

Add support for Python 3.12 audeering/audfactory#64

Open

allburov added the Help Wanted We will be glad if somebody proposes a solution via PR label Oct 10, 2023

briantist mentioned this issue Oct 11, 2023

Bump python from 3.11-slim to 3.12-slim briantist/galactory#118

Draft

briantist changed the title ~~Python 3.12 (pre-release) - AttributeError: module 'pathlib' has no attribute '_Flavour'~~ Python 3.12 - AttributeError: module 'pathlib' has no attribute '_Flavour' Nov 20, 2023

beliaev-maksim assigned zhan9san Feb 6, 2024

allburov unassigned zhan9san Mar 20, 2024

allburov added the hacktoberfest label Mar 20, 2024

This was referenced May 8, 2024

Add Dataset.example_media and cache Datacards audeering/audbcards#84

Merged

Depend on audbackend>=2.0.0 audeering/audbcards#90

Merged

ni-balexand mentioned this issue May 31, 2024

No support for Python3.12 #449

Closed

hagenw mentioned this issue Jun 18, 2024

pathlib._Flavour AttributeError when importing audb (Python 3.12) audeering/audb#432

Open

hagenw mentioned this issue Jul 10, 2024

Support for python3.12 audeering/opensmile-python#108

Open

konserw mentioned this issue Aug 30, 2024

module 'pathlib' has no attribute '_Accessor' #451

Closed

AaronOpfer mentioned this issue Sep 8, 2024

missing python version upper bound to prevent installation alongside 3.12 conda-forge/dohq-artifactory-feedstock#5

Open

1 task

shenxianpeng mentioned this issue Oct 7, 2024

Python 3.12 - AttributeError: module 'pathlib' has no attribute '_Flavour' devopshq/artifactory-cleanup#150

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Python 3.12 - AttributeError: module 'pathlib' has no attribute '_Flavour' #430

Python 3.12 - AttributeError: module 'pathlib' has no attribute '_Flavour' #430

briantist commented Aug 13, 2023 •

edited

Loading

allburov commented Aug 14, 2023

brot commented Sep 4, 2023

barneygale commented Oct 3, 2023

ktdreyer commented Dec 8, 2023

barneygale commented Dec 8, 2023

barneygale commented Dec 8, 2023

barneygale commented Dec 23, 2023

barneygale commented Dec 27, 2023

FHTMitchell commented Jan 24, 2024

dkmiller commented Feb 5, 2024

zhan9san commented Feb 6, 2024

barneygale commented Feb 24, 2024 •

edited

Loading

lukezhangtyler commented Mar 8, 2024

okainov commented Mar 19, 2024

allburov commented Mar 20, 2024

andrewsiemer commented Apr 10, 2024

hacklint commented May 3, 2024

barneygale commented Jun 7, 2024

mshafer-NI commented Jul 3, 2024

LeiYangGH commented Sep 10, 2024

seltsa commented Sep 10, 2024

LeiYangGH commented Sep 12, 2024

FrogWithASock commented Sep 18, 2024

allburov commented Sep 18, 2024

oscarm3l1n commented Sep 24, 2024

oscarm3l1n commented Sep 24, 2024

RoccoMatano commented Oct 8, 2024

hacklint commented Oct 11, 2024

LeiYangGH commented Oct 11, 2024

allburov commented Oct 14, 2024

Python 3.12 - AttributeError: module 'pathlib' has no attribute '_Flavour' #430

Python 3.12 - AttributeError: module 'pathlib' has no attribute '_Flavour' #430

Comments

briantist commented Aug 13, 2023 • edited Loading

allburov commented Aug 14, 2023

brot commented Sep 4, 2023

barneygale commented Oct 3, 2023

ktdreyer commented Dec 8, 2023

barneygale commented Dec 8, 2023

barneygale commented Dec 8, 2023

barneygale commented Dec 23, 2023

barneygale commented Dec 27, 2023

FHTMitchell commented Jan 24, 2024

dkmiller commented Feb 5, 2024

zhan9san commented Feb 6, 2024

barneygale commented Feb 24, 2024 • edited Loading

lukezhangtyler commented Mar 8, 2024

okainov commented Mar 19, 2024

allburov commented Mar 20, 2024

andrewsiemer commented Apr 10, 2024

hacklint commented May 3, 2024

barneygale commented Jun 7, 2024

mshafer-NI commented Jul 3, 2024

LeiYangGH commented Sep 10, 2024

seltsa commented Sep 10, 2024

LeiYangGH commented Sep 12, 2024

FrogWithASock commented Sep 18, 2024

allburov commented Sep 18, 2024

oscarm3l1n commented Sep 24, 2024

oscarm3l1n commented Sep 24, 2024

RoccoMatano commented Oct 8, 2024

hacklint commented Oct 11, 2024

LeiYangGH commented Oct 11, 2024

allburov commented Oct 14, 2024

briantist commented Aug 13, 2023 •

edited

Loading

barneygale commented Feb 24, 2024 •

edited

Loading