Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project still being maintained? #86

Open
David-Carty opened this issue Aug 17, 2018 · 7 comments
Open

Is this project still being maintained? #86

David-Carty opened this issue Aug 17, 2018 · 7 comments

Comments

@David-Carty
Copy link

Issues raised have not been acknowledged for almost a year. Grid seems a winner otherwise.

@TheKidCoder
Copy link
Contributor

TheKidCoder commented Aug 21, 2018

I believe it's still maintained. There is still commit activity and for the most part this is mostly a "finished" project. I'm sure @devlint would enjoy more community involvement to triage issues.

More than happy to help close out issues/triage issues if needed.

@devlint
Copy link
Owner

devlint commented Sep 20, 2018

Hello @David-Carty & @TheKidCoder !
The project can be maintained if I see new features or bugfixes I can do.
But help is welcome because it takes time that I've not today...

Thank you for your message, I appreciate very much!

@jepotter1-archive
Copy link

jepotter1-archive commented Jul 8, 2020

Hello @devlint, is the project still maintained in 2020? I want to use it in a CSS framework I'm developing, and I'm not sure whether I should just download it from NPM or maintain it myself as part of the framework.

If this project is abandoned, I'd be willing to step up as the new maintainer.

@jepotter1-archive
Copy link

It seems like @ChazUK has an actively maintined fork at https://github.com/ChazUK/grid. Do you have any plans to incorporate those changes upstream, or should I just use Charlie's fork?

@ChazUK
Copy link

ChazUK commented Jul 8, 2020

@JWinnie

Hi, I was looking at updating the default to become mobile first, but it's actually possible with the current repo.
I used the Bootstrap Breakpoints as they are pretty standard, and changed the Media Query to min-width.

$gl-gutter: 1rem;
$gl-mq-list: (
  sm: 576px,
  md: 768px,
  lg: 992px,
  xl: 1200px,
  xxl: 1440px,
);
$ql-mq-width: 'min-width';

I also added a few override changes to make the grid auto center.

[class~='grid'],
[class*='grid-'],
[class*='grid_'] {
  width: 100%;
  margin-left: auto;
  margin-right: auto;
  padding-left: ($gl-gutter / 2);
  padding-right: ($gl-gutter / 2);

  @each $breakpoint, $width in $gl-mq-list {
    @media (min-width: $width) {
      max-width: $width;
    }
  }
}

[class*='grid-'][class*='-noGutter'] {
  margin-left: auto;
  margin-right: auto;
  padding-left: $gl-gutter;
  padding-right: $gl-gutter;
}

What extra features are you looking for?

@jepotter1-archive
Copy link

I'm not looking for any features in particular. I just don't want to base my framework on an abandoned library.

@ChazUK
Copy link

ChazUK commented Jul 9, 2020

@JWinnie it might be worth looking at using Bootstraps grid instead, it’s robust, just switched to flexbox and is guaranteed to be maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants