Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated documentation on Azure deployment #787

Closed
robintw opened this issue Feb 29, 2024 · 3 comments
Closed

Outdated documentation on Azure deployment #787

robintw opened this issue Feb 29, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@robintw
Copy link
Contributor

robintw commented Feb 29, 2024

Problem description

The Azure deployment documentation at https://developmentseed.org/titiler/deployment/azure/ seems to be out-dated. The incorrect part seems to be in the Titiler parts rather than the Azure stuff - interestingly.

The following import fails:

from titiler.application.routers import cog, mosaic, stac, tms

I will try and submit a PR if I can find time, but I'm not quite sure what the modern way of importing those routers is - do I need to import the factories and register the routers from those?

@robintw robintw added the bug Something isn't working label Feb 29, 2024
@robintw
Copy link
Contributor Author

robintw commented Feb 29, 2024

Ah, just seen a PR fixing this at #680. Can that be merged soon to stop anyone else running into the same problems that I ran into?

@vincentsarago vincentsarago added documentation Improvements or additions to documentation and removed bug Something isn't working labels Mar 5, 2024
@vincentsarago
Copy link
Member

@robintw I'll have a look later this.

I didn't merge before because CI was failing and I was expecting the author to fix the issue

@vincentsarago
Copy link
Member

merged #680 so I guess we can close here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants