Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to dockerfile provided by openstreetmap-website #211

Open
willemarcel opened this issue Nov 26, 2021 · 3 comments
Open

Switch to dockerfile provided by openstreetmap-website #211

willemarcel opened this issue Nov 26, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@willemarcel
Copy link

willemarcel commented Nov 26, 2021

Since some months ago, there are some dockerfiles available in the openstreetmap-website repository. These dockerfiles are even used in the test suite. Although I don't know how ready for production they are, I believe they give us some confidence that it will be always compatible with the latest versions.

Should we consider switching to it? Their dockerfile seems much simpler than the osm-seed one, and probably would make it easier for us to keep it updated.

cc @batpad @Rub21

@willemarcel willemarcel changed the title Switch to docker file provided by openstreetmap-website Switch to dockerfile provided by openstreetmap-website Nov 26, 2021
@batpad
Copy link
Member

batpad commented Dec 7, 2021

I'm really hoping we can simplify our Dockerfile. However, am fairly certain that the container provided on the openstreetmap-website repo is for development use and not suitable for production. @Rub21 do you have a better idea? I can also do a bit more reading, but that seemed to be the case the last time I checked.

@Rub21
Copy link
Collaborator

Rub21 commented Dec 13, 2021

@batpad @willemarcel , It think this is something that we should try, the current Dockerfile does not support the latest version of openstreetmap-website and it is a disadvantage of osm-seed, i think for make it available for production we may need to consider some extra libraries such as. Passenger + Apache modulo .

@geohacker geohacker added the enhancement New feature or request label Jan 12, 2022
@spwoodcock
Copy link
Contributor

The official image https://github.com/openstreetmap/openstreetmap-website/blob/master/Dockerfile is not well optimised and far too bloated. I would not recommend it IMO.

Plus we need to add cgimap and our own init scripts anyway, so at best we will be extending it.

Note

I do think the osm-seed Dockerfile also needs to be optimised though.

This should be addressed by #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants