From 6a233d0f3236337d8699e59cf11d709cf0c026fc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Patrick=20St=C3=B6ckle?= <patrick.stoeckle@posteo.de>
Date: Thu, 1 Feb 2024 16:55:30 +0000
Subject: [PATCH 1/2] :sparkles: ansible-lint

---
 src/ansible-lint/README.md                 |  18 +++
 src/ansible-lint/devcontainer-feature.json |  21 +++
 src/ansible-lint/install.sh                |  22 +++
 src/ansible-lint/library_scripts.sh        | 170 +++++++++++++++++++++
 4 files changed, 231 insertions(+)
 create mode 100644 src/ansible-lint/README.md
 create mode 100644 src/ansible-lint/devcontainer-feature.json
 create mode 100755 src/ansible-lint/install.sh
 create mode 100644 src/ansible-lint/library_scripts.sh

diff --git a/src/ansible-lint/README.md b/src/ansible-lint/README.md
new file mode 100644
index 000000000..afea91f4a
--- /dev/null
+++ b/src/ansible-lint/README.md
@@ -0,0 +1,18 @@
+
+# Ansible-lint (via pipx) (ansible-lint)
+
+Checks playbooks for practices and behavior that could potentially be improved
+
+## Example Usage
+
+```json
+"features": {
+    "ghcr.io/devcontainers-contrib/features/ansible-lint:6": {}
+}
+```
+
+## Options
+
+| Options Id | Description | Type | Default Value |
+|-----|-----|-----|-----|
+| version | Select the version to install. | string | latest |
diff --git a/src/ansible-lint/devcontainer-feature.json b/src/ansible-lint/devcontainer-feature.json
new file mode 100644
index 000000000..54406d8ce
--- /dev/null
+++ b/src/ansible-lint/devcontainer-feature.json
@@ -0,0 +1,21 @@
+{
+    "name": "Ansible-lint (via pipx)",
+    "id": "ansible-lint",
+    "version": "6.22.2",
+    "description": "Checks playbooks for practices and behavior that could potentially be improved",
+    "options": {
+        "version": {
+            "default": "latest",
+            "description": "Select the version to install.",
+            "proposals": [
+                "latest"
+            ],
+            "type": "string"
+        }
+    },
+    "installsAfter": [
+        "ghcr.io/devcontainers-contrib/features/ansible",
+        "ghcr.io/devcontainers-contrib/features/pipx-package",
+        "ghcr.io/devcontainers/features/python"
+    ]
+}
diff --git a/src/ansible-lint/install.sh b/src/ansible-lint/install.sh
new file mode 100755
index 000000000..ab2c14a07
--- /dev/null
+++ b/src/ansible-lint/install.sh
@@ -0,0 +1,22 @@
+
+set -e
+
+. ./library_scripts.sh
+
+# nanolayer is a cli utility which keeps container layers as small as possible
+# source code: https://github.com/devcontainers-contrib/nanolayer
+# `ensure_nanolayer` is a bash function that will find any existing nanolayer installations,
+# and if missing - will download a temporary copy that automatically get deleted at the end
+# of the script
+ensure_nanolayer nanolayer_location "v0.5.0"
+
+
+$nanolayer_location \
+    install \
+    devcontainer-feature \
+    "ghcr.io/devcontainers-contrib/features/pipx-package:1.1.7" \
+    --option package='ansible-lint' --option version="$VERSION"
+
+
+
+echo 'Done!'
diff --git a/src/ansible-lint/library_scripts.sh b/src/ansible-lint/library_scripts.sh
new file mode 100644
index 000000000..d6730e499
--- /dev/null
+++ b/src/ansible-lint/library_scripts.sh
@@ -0,0 +1,170 @@
+
+
+clean_download() {
+    # The purpose of this function is to download a file with minimal impact on container layer size
+    # this means if no valid downloader is found (curl or wget) then we install a downloader (currently wget) in a
+    # temporary manner, and making sure to
+    # 1. uninstall the downloader at the return of the function
+    # 2. revert back any changes to the package installer database/cache (for example apt-get lists)
+    # The above steps will minimize the leftovers being created while installing the downloader
+    # Supported distros:
+    #  debian/ubuntu/alpine
+
+    url=$1
+    output_location=$2
+    tempdir=$(mktemp -d)
+    downloader_installed=""
+
+    _apt_get_install() {
+        tempdir=$1
+
+        # copy current state of apt list - in order to revert back later (minimize contianer layer size)
+        cp -p -R /var/lib/apt/lists $tempdir
+        apt-get update -y
+        apt-get -y install --no-install-recommends wget ca-certificates
+    }
+
+    _apt_get_cleanup() {
+        tempdir=$1
+
+        echo "removing wget"
+        apt-get -y purge wget --auto-remove
+
+        echo "revert back apt lists"
+        rm -rf /var/lib/apt/lists/*
+        rm -r /var/lib/apt/lists && mv $tempdir/lists /var/lib/apt/lists
+    }
+
+    _apk_install() {
+        tempdir=$1
+        # copy current state of apk cache - in order to revert back later (minimize contianer layer size)
+        cp -p -R /var/cache/apk $tempdir
+
+        apk add --no-cache  wget
+    }
+
+    _apk_cleanup() {
+        tempdir=$1
+
+        echo "removing wget"
+        apk del wget
+    }
+    # try to use either wget or curl if one of them already installer
+    if type curl >/dev/null 2>&1; then
+        downloader=curl
+    elif type wget >/dev/null 2>&1; then
+        downloader=wget
+    else
+        downloader=""
+    fi
+
+    # in case none of them is installed, install wget temporarly
+    if [ -z $downloader ] ; then
+        if [ -x "/usr/bin/apt-get" ] ; then
+            _apt_get_install $tempdir
+        elif [ -x "/sbin/apk" ] ; then
+            _apk_install $tempdir
+        else
+            echo "distro not supported"
+            exit 1
+        fi
+        downloader="wget"
+        downloader_installed="true"
+    fi
+
+    if [ $downloader = "wget" ] ; then
+        wget -q $url -O $output_location
+    else
+        curl -sfL $url -o $output_location
+    fi
+
+    # NOTE: the cleanup procedure was not implemented using `trap X RETURN` only because
+    # alpine lack bash, and RETURN is not a valid signal under sh shell
+    if ! [ -z $downloader_installed  ] ; then
+        if [ -x "/usr/bin/apt-get" ] ; then
+            _apt_get_cleanup $tempdir
+        elif [ -x "/sbin/apk" ] ; then
+            _apk_cleanup $tempdir
+        else
+            echo "distro not supported"
+            exit 1
+        fi
+    fi
+
+}
+
+
+ensure_nanolayer() {
+    # Ensure existance of the nanolayer cli program
+    local variable_name=$1
+
+    local required_version=$2
+
+    local __nanolayer_location=""
+
+    # If possible - try to use an already installed nanolayer
+    if [ -z "${NANOLAYER_FORCE_CLI_INSTALLATION}" ]; then
+        if [ -z "${NANOLAYER_CLI_LOCATION}" ]; then
+            if type nanolayer >/dev/null 2>&1; then
+                echo "Found a pre-existing nanolayer in PATH"
+                __nanolayer_location=nanolayer
+            fi
+        elif [ -f "${NANOLAYER_CLI_LOCATION}" ] && [ -x "${NANOLAYER_CLI_LOCATION}" ] ; then
+            __nanolayer_location=${NANOLAYER_CLI_LOCATION}
+            echo "Found a pre-existing nanolayer which were given in env variable: $__nanolayer_location"
+        fi
+
+        # make sure its of the required version
+        if ! [ -z "${__nanolayer_location}" ]; then
+            local current_version
+            current_version=$($__nanolayer_location --version)
+
+
+            if ! [ $current_version == $required_version ]; then
+                echo "skipping usage of pre-existing nanolayer. (required version $required_version does not match existing version $current_version)"
+                __nanolayer_location=""
+            fi
+        fi
+
+    fi
+
+    # If not previuse installation found, download it temporarly and delete at the end of the script
+    if [ -z "${__nanolayer_location}" ]; then
+
+        if [ "$(uname -sm)" = 'Linux x86_64' ] || [ "$(uname -sm)" = "Linux aarch64" ]; then
+            tmp_dir=$(mktemp -d -t nanolayer-XXXXXXXXXX)
+
+            clean_up () {
+                ARG=$?
+                rm -rf $tmp_dir
+                exit $ARG
+            }
+            trap clean_up EXIT
+
+
+            if [ -x "/sbin/apk" ] ; then
+                clib_type=musl
+            else
+                clib_type=gnu
+            fi
+
+            tar_filename=nanolayer-"$(uname -m)"-unknown-linux-$clib_type.tgz
+
+            # clean download will minimize leftover in case a downloaderlike wget or curl need to be installed
+            clean_download https://github.com/devcontainers-contrib/cli/releases/download/$required_version/$tar_filename $tmp_dir/$tar_filename
+
+            tar xfzv $tmp_dir/$tar_filename -C "$tmp_dir"
+            chmod a+x $tmp_dir/nanolayer
+            __nanolayer_location=$tmp_dir/nanolayer
+
+
+        else
+            echo "No binaries compiled for non-x86-linux architectures yet: $(uname -m)"
+            exit 1
+        fi
+    fi
+
+    # Expose outside the resolved location
+    export ${variable_name}=$__nanolayer_location
+
+}

From aa025076ed3340ff2b67ef2aaf80dbfde9a4cb8c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Patrick=20St=C3=B6ckle?= <patrick.stoeckle@posteo.de>
Date: Thu, 1 Feb 2024 16:55:47 +0000
Subject: [PATCH 2/2] :white_check_mark: ansible-lint

---
 test/ansible-lint/scenarios.json            | 10 ++++++++++
 test/ansible-lint/test.sh                   | 11 +++++++++++
 test/ansible-lint/test_version_selection.sh | 14 ++++++++++++++
 3 files changed, 35 insertions(+)
 create mode 100644 test/ansible-lint/scenarios.json
 create mode 100644 test/ansible-lint/test.sh
 create mode 100644 test/ansible-lint/test_version_selection.sh

diff --git a/test/ansible-lint/scenarios.json b/test/ansible-lint/scenarios.json
new file mode 100644
index 000000000..9f344d3b3
--- /dev/null
+++ b/test/ansible-lint/scenarios.json
@@ -0,0 +1,10 @@
+{
+    "test_version_selection": {
+        "image": "mcr.microsoft.com/devcontainers/base:bookworm",
+        "features": {
+            "ansible-lint": {
+                "version": "6.22.2"
+            }
+        }
+    }
+}
diff --git a/test/ansible-lint/test.sh b/test/ansible-lint/test.sh
new file mode 100644
index 000000000..100c6b77f
--- /dev/null
+++ b/test/ansible-lint/test.sh
@@ -0,0 +1,11 @@
+#!/bin/bash
+
+set -e
+
+source dev-container-features-test-lib
+
+check "test for version" ansible-lint --version
+
+# Report result
+# If any of the checks above exited with a non-zero exit code, the test will fail.
+reportResults
diff --git a/test/ansible-lint/test_version_selection.sh b/test/ansible-lint/test_version_selection.sh
new file mode 100644
index 000000000..31c9fabea
--- /dev/null
+++ b/test/ansible-lint/test_version_selection.sh
@@ -0,0 +1,14 @@
+#!/bin/bash
+
+set -e
+
+# Optional: Import test library bundled with the devcontainer CLI
+source dev-container-features-test-lib
+
+# Feature-specific tests
+# The 'check' command comes from the dev-container-features-test-lib.
+check "execute command" bash -c "ansible-lint --version | grep '6.22.2'"
+
+# Report result
+# If any of the checks above exited with a non-zero exit code, the test will fail.
+reportResults