Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add particle species in ParticleBeam #231

Open
jp-ga opened this issue Jul 25, 2024 · 3 comments
Open

add particle species in ParticleBeam #231

jp-ga opened this issue Jul 25, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jp-ga
Copy link
Collaborator

jp-ga commented Jul 25, 2024

I have noticed that ParticleBeam doesn't have a particle mass property. It ends up being necessary to assume particles are electrons and then import the electron mass for different elements/tracking routines. It would be useful to add the particle mass or species to ParticleBeam and use electrons as default.

@jp-ga
Copy link
Collaborator Author

jp-ga commented Jul 25, 2024

Any thoughts on this @jank324 @cr-xu ?

@jp-ga jp-ga changed the title add particle mass in ParticleBeam add particle species in ParticleBeam Jul 25, 2024
@jank324
Copy link
Member

jank324 commented Jul 25, 2024

Any thoughts on this @jank324 @cr-xu ?

This was discussed somewhere before, I don't remember where. In the end we didn't do it (yet) because we didn't need this yet.

I don't see any reason why we shouldn't add it.

@cr-xu
Copy link
Member

cr-xu commented Jul 29, 2024

Yes, we should add this. It's just been on the to-do list for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants