Skip to content
This repository has been archived by the owner on May 24, 2021. It is now read-only.

Date Slider and Null Dates #26

Open
nb-ofs opened this issue Oct 30, 2013 · 2 comments
Open

Date Slider and Null Dates #26

nb-ofs opened this issue Oct 30, 2013 · 2 comments
Labels

Comments

@nb-ofs
Copy link
Contributor

nb-ofs commented Oct 30, 2013

following the code from here...

https://github.com/derekeder/FusionTable-Map-Template/wiki/Filter-examples#wiki-date-sliders

any null dates are excluded from the dataset results by default.

possibility of including null dates requires consideration.

@derekeder
Copy link
Owner

@nb-ofs could you give a little more background or provide some pseudo-code for this? Could it be handled as a special case with a checkbox for 'no date' ?

@nb-ofs
Copy link
Contributor Author

nb-ofs commented Nov 4, 2013

It appears that moment(null); is valid in terms of validation when reviewing momentjs documentation ( http://momentjs.com/docs/#/parsing/is-valid/ )

this appears to be included after version 2 which https://github.com/derekeder/FusionTable-Map-Template/wiki/Filter-examples#wiki-date-sliders points at...

latest version 2.4.0...

example
https://fisonline.tribalhosted.co.uk/Kent/Publications/FusionMapTable/Rewrite_Dev/index.html totals 1728 records when all types are selected

whereas
https://fisonline.tribalhosted.co.uk/Kent/Publications/FusionMapTable/Rewrite/index.html totals 1845 records

Inclusion of a null could be handled by a checkbox to include / exclude as required

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants