Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder should have some way to specify compile-time options to addons #27

Open
ghost opened this issue Jun 20, 2017 · 2 comments
Open

Comments

@ghost
Copy link

ghost commented Jun 20, 2017

There are some addons (e.g. denali-mailer) that do some custom build behavior of the app they are installed to. Currently (unless I skimmed too quickly), there is not a way to do that. The denali-build.js returns an extension of Builder, so it shouldn't be too difficult to standardize a way of adding configuration that addons can then check.

Note: I'm drawing this idea from Ember's ability to pass in configuration to addons via the ember-cli-build.js file.

@davewasmer
Copy link
Contributor

Customization of the consuming app's tree should be possible via processParent() on the builder. Or am I misunderstanding?

@acburdine
Copy link
Member

acburdine commented Jun 20, 2017

I'm saying apps should have some standardized way to pass configure options to an addon that's building the app via processParent.

Say there's some config value an app can set for denali-babel. denali-babel looks to see if config value exists in the parent (app/addon), then potentially changes how it runs depending on that config value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants