Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Entering some sort of join link or room id into the search after pressing the "+" button doesn't offer to let me join #4158

Open
ell1e opened this issue Oct 1, 2024 · 9 comments
Labels
ui/ux UI/UX related issues

Comments

@ell1e
Copy link

ell1e commented Oct 1, 2024

I found a chat room that I was asked to join, and it's specified via some OPENPGP4FPR:... id. Alternatively, I was given a link starting with https://i.delta.chat/#....

Neither will open in the regular desktop chat client if I enter them in the two obvious locations:

Screenshot_20241001_184143

Screenshot_20241001_184027

This makes it unnecessarily confusing to figure out how to even join a room without a mobile phone. I suggest that this is changed.

  • Operating System (Linux/Mac/Windows/iOS/Android):
  • Delta Chat Version: Desktop 1.46.8 Core v1.142.12 SQLite 3.45.3 electron 30.3.1 node 20.15.1
  • Expected behavior: entering both this room id and the given join link into either of the two search fields works
  • Actual behavior: neither the room id nor the join link seems to be recognized by any of the search fields
  • Steps to reproduce the problem: try to enter a room id or join link into the input fields marked above
  • Screenshots: see above
  • Logs: probably not relevant!
@Simon-Laux
Copy link
Member

Simon-Laux commented Oct 2, 2024

great idea!

For now you can also send the link in self send/saved messages and click on it. Or "scan" it with the settings wheel in the qr code scanner dialog.

CC @r10s (what do you think?)

@WofWca
Copy link
Collaborator

WofWca commented Oct 2, 2024

I thought I added this to the chat list search in #4041, which was released in 1.46.2...

There was another small improvement #4151, which is not released yet.
And @nicodh suggested to add this to the contact search as well: #4151 (review)

@WofWca WofWca added the ui/ux UI/UX related issues label Oct 2, 2024
@r10s
Copy link
Member

r10s commented Oct 2, 2024

I thought I added this to the chat list search in #4041, which was released in 1.46.2...

yeah, i can confirm, that it works in general.

but it seems too implicit, to show the generic "New Contact" button that is shown at other places as well, where the user has to enter an email address.

as a quick improvement, the button could read "Chat with CHATNAME".

@WofWca
Copy link
Collaborator

WofWca commented Oct 2, 2024

An even better improvement would be to read the clipboard, detect that it's an invite link, and suggest appropriate action.

@ell1e
Copy link
Author

ell1e commented Oct 2, 2024

It may seem a little weird if an app is constantly watching to clipboard changes even when no button is pressed, at least I personally don't know any app that does it. Maybe that's just me though?

it seems too implicit, to to show the generic "New Contact" button that is shown at other places as well,

You're saying after pasting I would have simply needed to click that? Interesting, that didn't occur to me since it didn't reflect a clear reaction to recognizing a room. I would suggest it should change to "Join group chat [group chat name]" or something, when a group chat reference was pasted.

@r10s
Copy link
Member

r10s commented Oct 3, 2024

we should stay with manual paste.

always watching the clipboard is considered at least strange. some os even show a hint every time the clipboard is read - even if that is not yet the case now for desktop, it might be cause for trouble in the future.

@WofWca
Copy link
Collaborator

WofWca commented Oct 3, 2024

the button could read "Chat with CHATNAME".

We have "Chat with %1?", with a question mark.

<string name="ask_start_chat_with">Chat with %1$s?</string>

Shall we use this string, or make a new one?

@r10s
Copy link
Member

r10s commented Oct 3, 2024

better a new one without the question mark.

question marks on button-like controls are unusual.

@WofWca
Copy link
Collaborator

WofWca commented Oct 3, 2024

Actually you know what. I think we can simply display the item as a contact. I.e. move the name to the header and empty the subheader (or replace it with the email address). No need for call-to-action texts. Since an invite link is practically a link to a contact. What do you think?

@WofWca WofWca self-assigned this Oct 3, 2024
WofWca added a commit that referenced this issue Oct 5, 2024
Swap the sub and main text.
Partially addresses #4158.
WofWca added a commit that referenced this issue Oct 5, 2024
when pasting an invite link into the search field.

Partially addresses #4158.
WofWca added a commit that referenced this issue Oct 5, 2024
when pasting an invite link into the search field.

Partially addresses #4158.
@WofWca WofWca removed their assignment Oct 5, 2024
WofWca added a commit that referenced this issue Oct 10, 2024
when pasting an invite link into the search field.

Partially addresses #4158.
WofWca added a commit that referenced this issue Oct 10, 2024
Swap the sub and main text.
Partially addresses #4158.
WofWca added a commit that referenced this issue Oct 10, 2024
when pasting an invite link into the search field.

Partially addresses #4158.
WofWca added a commit that referenced this issue Oct 10, 2024
Swap the sub and main text.
Partially addresses #4158.
WofWca added a commit that referenced this issue Oct 10, 2024
when pasting an invite link into the search field.

Partially addresses #4158.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux UI/UX related issues
Projects
None yet
Development

No branches or pull requests

4 participants