Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to recover initial memory state in GP #2129

Open
dalkia opened this issue Sep 23, 2024 · 7 comments
Open

Unable to recover initial memory state in GP #2129

dalkia opened this issue Sep 23, 2024 · 7 comments
Assignees
Labels
0-critical Highly important issues that should be prioritised bug Something isn't working
Milestone

Comments

@dalkia
Copy link
Collaborator

dalkia commented Sep 23, 2024

(Tested in Mac)

Do the following steps

  1. Start out in Genesis Plaza and check out the memory.
  2. Teleport away to any given scene, and see the memory increase.
  3. Go back to GP and press the FULL button in the Memory debug window.

Memory should be about the same, but there is a clear difference. We have to find out why since this indicates there is a leak

Example in MAC

Initial state
image

Teleport to scene -145,69
image

Went back to GP and pressed FULL
image

Memory is now at around 8100MB vs 7700MB from start. There are an extra 400MB that shouldnt be there

@dalkia dalkia added the bug Something isn't working label Sep 23, 2024
@github-actions github-actions bot added the new Issues to triage label Sep 23, 2024
@m3taphysics m3taphysics added 1-high Very important but not critical or game breaking 0-critical Highly important issues that should be prioritised and removed new Issues to triage 1-high Very important but not critical or game breaking labels Sep 23, 2024
@m3taphysics m3taphysics assigned dalkia and QThund and unassigned dalkia Sep 23, 2024
@QThund
Copy link
Collaborator

QThund commented Sep 25, 2024

It seems that it does not happen when teleporting between worlds (I mean, when not visiting Genesis).

@QThund
Copy link
Collaborator

QThund commented Sep 27, 2024

Detected memory leaks, textures related to NFTs are not referenced by any object. Steps to reproduce:

  1. Enter Genesis.
  2. Go to Olavra.
  3. Go to Genesis.
  4. Go to Olavra. Take first snapshot with Memory Profiler.
  5. Go to Genesis.
  6. Go to Olavra. Take second snapshot.
  7. Compare both snapshots in Memory profiler.
    However, it does not happen always, sometimes textures are referenced by some objects.

Image

@QThund
Copy link
Collaborator

QThund commented Sep 27, 2024

After Misha's changes (#2182) that situation should be solved. I tested it and references are tracked by the cache, so they can safely be freed once memory gets full.

@QThund
Copy link
Collaborator

QThund commented Sep 27, 2024

Maybe a decision has to be made regarding whether those images should stay in memory when moving to another world or not.

@QThund
Copy link
Collaborator

QThund commented Oct 2, 2024

These accumulation of images related to NFTs were detected in Misha's branch. He has already fixed it.
Image

@QThund
Copy link
Collaborator

QThund commented Oct 2, 2024

This duplication of textures has been detected, although the number does not grow when moving to other worlds.
Image

@QThund
Copy link
Collaborator

QThund commented Oct 2, 2024

After checking this increment in Avatar-related game objects, I concluded they are part of pools that may not be reusing objects, it should be investigated (are the pools cleared without releasing all their elements first?)
Image

@m3taphysics m3taphysics added this to the Beta Release milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-critical Highly important issues that should be prioritised bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants