Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech Debt: Manage Input locking properly #1817

Closed
fcolarich opened this issue Aug 19, 2024 · 1 comment
Closed

Tech Debt: Manage Input locking properly #1817

fcolarich opened this issue Aug 19, 2024 · 1 comment
Assignees
Labels
2-medium Important issues we must fix, but not as important as high! new Issues to triage tech debt

Comments

@fcolarich
Copy link
Collaborator

Currently, our input locking/unlocking is messy, we have a system that should be taking care of it, but its not used everywhere and nevertheless, there is no prio for locking/unlocking, so anyone can lock/unlock at any moment and it makes it much harder to control it.
I was trying to lock input during the loading screen showing, but then when the chat loses focus it enables input so it would nullify it, or when the explore panel closes, it also enables certain inputs, etc., etc.

So we need a more proper way to discern who can lock/unlock input and when.

@fcolarich fcolarich self-assigned this Aug 19, 2024
@github-actions github-actions bot added the new Issues to triage label Aug 19, 2024
@fcolarich fcolarich added tech debt and removed new Issues to triage labels Aug 19, 2024
@aixaCode aixaCode added the 2-medium Important issues we must fix, but not as important as high! label Aug 19, 2024
@fcolarich
Copy link
Collaborator Author

This PR addresses this, but we discussed with Vitaly some more optimizations that can be done, so I will keep this one alive for that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-medium Important issues we must fix, but not as important as high! new Issues to triage tech debt
Projects
None yet
Development

No branches or pull requests

2 participants