Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy dependency connected-react-router #624

Open
meelrossi opened this issue Jun 3, 2024 · 1 comment
Open

Remove legacy dependency connected-react-router #624

meelrossi opened this issue Jun 3, 2024 · 1 comment
Assignees

Comments

@meelrossi
Copy link
Contributor

meelrossi commented Jun 3, 2024

Remove connected-react-router from dependencies. Use history object instead to redirect from the sagas

@meelrossi meelrossi changed the title Remove connected-react-router from dependencies. Use history object instead to redirect from the sagas Remove legacy dependency connected-react-router Jun 3, 2024
@meelrossi
Copy link
Contributor Author

meelrossi commented Jun 3, 2024

  • Move analytics page track to a hook instead of using LOCATION_CHANGE action (link)
  • Remove location change saga from modals module (account) (builder)
  • Refactor third party routing module to not use connected react router (link)
  • Use history instead of push to change locations in sagas
  • Refactor locations module in account to not use connected-react-router (link)
  • Refactor routing module in marketplace to not use connected-react-router (link
  • Refactor store module in marketplace to not use connected-react-router (link)
  • Remove ConnectedRouter provider from all dapps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant