Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change property visibility and make SOAP client options configurable for VIES client #27

Open
fnagel opened this issue Aug 16, 2018 · 1 comment

Comments

@fnagel
Copy link

fnagel commented Aug 16, 2018

We want to change the URL address and add a SOAP client timeout.

It would be helpful if the $wsdl property would be changed to protected (in order to extend the class and change the property) and if the options passed into the \SoapClient (second parameter) would be configurable using a protected property.

Related file is ddeboer/vatin/src/Vies/Client.php

@ddeboer
Copy link
Owner

ddeboer commented Jan 5, 2019

It would be helpful if the $wsdl property would be changed to protected

Is this necessary? You should be able to call parent::__construct($wsdl).

if the options passed into the \SoapClient (second parameter) would be configurable using a protected property.

Good point. What about adding the SoapClient options as a second constructor argument to Client?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants