Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename front-page form field to prevent browser auto-suggestion #125

Open
patcon opened this issue Feb 22, 2017 · 2 comments
Open

Rename front-page form field to prevent browser auto-suggestion #125

patcon opened this issue Feb 22, 2017 · 2 comments

Comments

@patcon
Copy link
Contributor

patcon commented Feb 22, 2017

@gabesawhney and Hillary Lorimer have been leading user testing, and one small thing that came up repeatedly was the confusion over our "auto-complete" that they were seeing on the front page legislation search field.

Turns out that it's a helpful browser feature that is based on the form field "name" attribute. We chose to use "q", and so that's shared with many other forms (like google)

https://github.com/datamade/django-councilmatic/blob/master/councilmatic_core/templates/councilmatic_core/index.html#L22

Any objection to changing this to something more unique, like "legislation-search"?

@patcon
Copy link
Contributor Author

patcon commented Feb 22, 2017

Actually, seems that the request.GET.q is baked pretty deeply (and it's self-explanatory), so likely want to avoid changing that :)

Seems that adding an "id" attrib might resolve it:
https://cloudfour.com/thinks/autofill-what-web-devs-should-know-but-dont/

@patcon
Copy link
Contributor Author

patcon commented Feb 22, 2017

Seems that adding an "id" to the input tag doesn't actually resolve anything on FF -- only changing "name" value does that. That seems odd, as "q" is a very common querystring, and I would have thought this would come up elsewhere.

What about simply setting autocomplete="off"? It sucks to lose, but right now it's autocompleting with previous google searches, which is pretty confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant