Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional "version" input #30

Closed
connorbrown-8451 opened this issue Aug 2, 2023 · 3 comments · Fixed by #32
Closed

Add optional "version" input #30

connorbrown-8451 opened this issue Aug 2, 2023 · 3 comments · Fixed by #32

Comments

@connorbrown-8451
Copy link

It would be nice to have an optional "version" input for this action that allows users to pin the version of the Databricks CLI to a specific release.

For example:

steps:
  - uses: databricks/setup-cli@main
    with:
      version: '0.201.0'

If the input is not provided, I think it should default to the "latest" version if possible.
@pietern
Copy link
Collaborator

pietern commented Aug 10, 2023

I agree -- there's 2 dimensions:

  • The tags in the repository itself
  • Setting the version when using the action from the main branch

The first one is for the curl | bash installer colocated in this repository.

If the first is done, you could also lock to a CLI by using databricks/[email protected], for example.

pietern added a commit that referenced this issue Aug 10, 2023
@pietern
Add version parameter to action
d95aa58 
If not specified, this defaults to "latest" and uses the version encoded in the `VERSION` file.

Otherwise, it downloads and installs the specified version.

Closes #30.
@pietern pietern mentioned this issue Aug 10, 2023
Merged
@pietern
Copy link
Collaborator

pietern commented Aug 10, 2023

PR #32 implements the 2nd approach.

@pietern
Copy link
Collaborator

pietern commented Aug 11, 2023

@connorbrown-8451 This is now ready to use.

@pietern pietern mentioned this issue Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add version parameter to action databricks/setup-cli
2 participants
@pietern @connorbrown-8451