-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symlinks ignored when uploading asset bundles #1706
Comments
This is resolved with #1708 |
Would be awesome to get this upstreamed. I have started to build some bazel rules around this so you can start doing stuff like this.
However it feels a little strange to open source this and have it pointing to my internal builds of the databricks CLI. |
@michaelschuett-tomtom what is the reason you use symlinks in your bundle? I assume to link the content outside of bundle root? If so, in the latest CLI (0.227.0) we have a new functionality |
The goal here is mainly to make databricks play nicely with the bazel build system. The current problem is when bazel builds it's sandbox for commands to run inside of it creates some ugly path under Here is an example of what the directory might look like.
The title of this could likely be "I want to make databricks asset bundles work with bazel". The |
Just a bump on this to try and keep it from becoming stale since I currently have the time to work or modify the linked PR provided upstream is willing to accept it. |
@michaelschuett-tomtom Thanks for posting the issue and including the rationale. It's great to hear you're looking to make the CLI work well with Bazel. There are a couple of reasons why we ignore symlinks:
This doesn't help in building working Bazel rules, of course. But if you really only care about locally unrolling the symlink tree that Bazel builds, an alternative could be to run |
Describe the issue
I have a symlink in my directory and it is silently ignored when uploading to the
files
folder. The databricks.yml files andresources
that is loads are symlinks as well however it is able to read them. I can't find any docs about this but I likely missed something. Any reason that symlinks are not supported.Configuration
Create a symlink run
databricks bundle deploy
and see that it is missing.Steps to reproduce the behavior
Please list the steps required to reproduce the issue, for example:
databricks bundle deploy ...
databricks bundle run ...
Expected Behavior
A warning is output or better yet it just uploads the file.
Actual Behavior
It is silently ignored.
OS and CLI version
mac OS, all versions
Is this a regression?
no
The text was updated successfully, but these errors were encountered: