Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional test cases #33

Open
jonasfj opened this issue Feb 10, 2023 · 5 comments
Open

Additional test cases #33

jonasfj opened this issue Feb 10, 2023 · 5 comments
Labels
good first issue A good starting issue for contributors (issues with this label will appear in /contribute)

Comments

@jonasfj
Copy link
Member

jonasfj commented Feb 10, 2023

This package could use more test cases.

Both of the kind in here:
https://github.com/dart-lang/yaml_edit/tree/main/test/testdata

And of the kind written in test/*_test.dart.

Issues like broken string escaping noticed in #28 indicate that we could probably use more test cases.

An approach to systematically test more of the code, or perhaps some code-coverage could be useful to.

@jonasfj jonasfj added the good first issue A good starting issue for contributors (issues with this label will appear in /contribute) label Feb 10, 2023
@MikiPAUL
Copy link
Contributor

@jonasfj , I would love to take on this task! I am confident that I can make a contribution here. Would you mind assigning this issue to me? Thank you!

@jonasfj
Copy link
Member Author

jonasfj commented Feb 16, 2023

Sure, no problem.

@jonasfj
Copy link
Member Author

jonasfj commented Feb 20, 2023

Honestly, anyone is welcome to help write a few test cases. Especially, if we can make some test cases that finds new bugs, then we can file issues to fix those bugs :D

@jonasfj
Copy link
Member Author

jonasfj commented Mar 1, 2023

In particular, we need test cases for strings that contain special characters, line breaks and the lines. I think we have issues when such strings are formatted as folded strings, etc.

@seifibrahim32
Copy link

@jonasfj I will add some tests before I try to add for #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good starting issue for contributors (issues with this label will appear in /contribute)
Projects
None yet
Development

No branches or pull requests

3 participants