Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm integration tests are not running on firefox #2288

Open
natebosch opened this issue Oct 1, 2024 · 1 comment
Open

wasm integration tests are not running on firefox #2288

natebosch opened this issue Oct 1, 2024 · 1 comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@natebosch
Copy link
Member

#2285 highlighted that no tests are running on firefox in the integration_test/wasm directory, but it is not failing. When running on firefox alone we fail because no test cases run. There is a retry reported, then nothing. When running on both firefox and chrome, because the test cases do run on chrome, so we don't fail with the overall run having no test cases. Our check for no test cases is across suites, not per suite, but this might suggest we should change that.

@natebosch natebosch added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Oct 1, 2024
@osa1
Copy link
Member

osa1 commented Oct 2, 2024

It looks like the Firefox version we use in CI is buggy. I'm able to reproduce this with Firefox 115.15.0, but not with the latest stable (131.0).

The behavior in version 115.15.0 is that it reports a Wasm validation error, which should be a bug in Firefox as the module is valid according to multiple other tools.

The reason why the test hangs is because it does not handle errors thrown in this line:

let compiledModule = await dart2wasmJsRuntime.compileStreaming(
fetch(data.wasmurl),
);
A similar issue existed in Flutter's test runner (felt) as well, which we fixed in flutter/engine#55166.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants