From ef7c98d2a80f1c6d4f7af57c4e8279fa597c0873 Mon Sep 17 00:00:00 2001 From: Nate Bosch Date: Fri, 22 Mar 2024 18:00:37 +0000 Subject: [PATCH] Try removing isolate.kill() Originally isolates were killed when the loader was closed as the runner is shutting down. There was no comment in the review about the specific reason for `isolate.kill()`. https://codereview.chromium.org//920703006 Later the kill was moved to when the test suite is done. There was no specific comment about the `isolate.kill()` changes. https://codereview.chromium.org//1206033004 No internal tests seem to be relying on this behavior, and nothing times out when it is removed. Check whether there are any tests on CI that validate this behavior. --- pkgs/test_core/lib/src/runner/vm/platform.dart | 1 - 1 file changed, 1 deletion(-) diff --git a/pkgs/test_core/lib/src/runner/vm/platform.dart b/pkgs/test_core/lib/src/runner/vm/platform.dart index aa4eeb81a..512f7db43 100644 --- a/pkgs/test_core/lib/src/runner/vm/platform.dart +++ b/pkgs/test_core/lib/src/runner/vm/platform.dart @@ -80,7 +80,6 @@ class VMPlatform extends PlatformPlugin { rethrow; } outerChannel = MultiChannel(IsolateChannel.connectReceive(receivePort)); - cleanupCallbacks.add(isolate.kill); } cleanupCallbacks.add(outerChannel.sink.close);