-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge into package:async #111
Comments
Also tracking at dart-lang/async#117 |
Taking a note just in case - if we end up deciding not to do this for some reason (I don't expect we would) we should consider reviving dart-lang/site-www#2974 |
@lrhn wdyt about merging this in as |
I migth want to go through the operations a little more thoroughly before accepting them in (A quick check showed the |
Towards #111 The default callback is not used in practice outside of tests, but it included a cast to satisfy the type signature which looks worrying for this type of library. Make the callback required and add explicit callbacks (without a cast since the types are consistent) in the tests which used it.
The default callback isn't used outside of tests, and there it uses consistent types and doesn't need the cast. We can mark it required and avoid the misleading cast. |
I checked more, and there are definitely things I'd want to update (using I did try chaingng |
Towards #111 The default callback is not used in practice outside of tests, but it included a cast to satisfy the type signature which looks worrying for this type of library. Make the callback required and add explicit callbacks (without a cast since the types are consistent) in the tests which used it.
Towards #111 During the null safety migration it was possible for `StreamSubscription.cancel()` to return `null` in some cases. Now that this package is only used with sound null safe code it isn't possible for these nulls to flow through anymore so it is not necessary to filter for them.
Towards #111 During the null safety migration it was possible for `StreamSubscription.cancel()` to return `null` in some cases. Now that this package is only used with sound null safe code it isn't possible for these nulls to flow through anymore so it is not necessary to filter for them.
We should consider merging this into https://pub.dev/packages/async
cc @natebosch
The text was updated successfully, but these errors were encountered: