Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The caller should be able to override the id value #85

Open
t33x opened this issue Jul 21, 2022 · 0 comments
Open

The caller should be able to override the id value #85

t33x opened this issue Jul 21, 2022 · 0 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@t33x
Copy link

t33x commented Jul 21, 2022

The JSON-RPC transport agnostic. The current implementation uses an auto-increment number (which always starts from zero) as the id value. This is appropriate for a point-to-point type transport (e.g. socket based protocols), but for MQTT, for example, this could potentially cause problems when the server replies are received by all clients, and clients start sending requests at the same time but with different parameters (but with same id started from zero). JSON-RPC states that the id can be of string type. If clients were able to choose a unique string value specific to them as the id value, it could be safely used with MQTT in all cases.

@devoncarew devoncarew added the type-enhancement A request for a change that isn't a bug label Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants