Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the Result type to sealed classes #251

Open
exaby73 opened this issue Sep 20, 2023 · 5 comments
Open

Migrate the Result type to sealed classes #251

exaby73 opened this issue Sep 20, 2023 · 5 comments

Comments

@exaby73
Copy link

exaby73 commented Sep 20, 2023

Since we have had Dart 3, we have access to sealed classes. I propose we migrate the Result class to sealed instead of abstract. I have done so in a fork. See the comparison. But since the minimum version had to be changed to >=3.0.0 <4.0.0, I'd like to first discuss this

@lrhn
Copy link
Member

lrhn commented Sep 26, 2023

The entire package should be migrated to Dart 3.0. That would be one of the changes.

@exaby73
Copy link
Author

exaby73 commented Oct 2, 2023

What would be the process for this? Maybe the min version would be updated first, then the migration of the code, or everything in one PR?

@utamori
Copy link

utamori commented Aug 11, 2024

@exaby73 @kevmoo
this package minimum sdk version has been updated, so I think the barrier to Sealed Class is gone!

@kevmoo
Copy link
Member

kevmoo commented Aug 12, 2024

you mean minimum SDK version?

@utamori
Copy link

utamori commented Sep 19, 2024

This line was updated.

@exaby73 , do you want to create a PR? Shall I make one?

sdk: ^3.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants