Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add purge options #638

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add purge options #638

wants to merge 1 commit into from

Conversation

famarting
Copy link
Contributor

@famarting famarting commented Oct 14, 2024

Description

blocked by microsoft/durabletask-go#82

closes #497

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 61.54%. Comparing base (27248ba) to head (525ff6a).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
workflow/client.go 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
+ Coverage   58.04%   61.54%   +3.49%     
==========================================
  Files          55       56       +1     
  Lines        3568     3440     -128     
==========================================
+ Hits         2071     2117      +46     
+ Misses       1375     1197     -178     
- Partials      122      126       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Fabian Martinez <[email protected]>
@famarting famarting marked this pull request as ready for review October 16, 2024 10:56
@famarting famarting requested review from a team as code owners October 16, 2024 10:56
@famarting famarting changed the title wip: add purge options add purge options Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cascade Terminate/Purge support for Workflow
1 participant