Swift 3.2/4.0 support

[AtharvaVaidya]

Are there plans to update this library to Swift 3.2 or 4.0?

[danthorpe]

Hi @AtharvaVaidya - it is certainly my desire to maintain the project for Swift 3.2 & Swift 4.0. I will hopefully get to Swift 3.2 in the next week or so.

On a larger point, I'm mulling over potential changes for a v3 of the library which would accommodate initialisation from string values such as "USD 10" or "10USD" - which is currently not possible.

[hdoria]

+1

[AtharvaVaidya]

The string initialization would be a very welcome addition. I'd be glad to help implement it.

[mattcorey]

Swift 3.2/4.0 compatibility seems to be a more basic need - any focus on this would be appreciated!

[lmcd]

👍
Looking to migrate a large project.

[maximkhatskevich]

@danthorpe Were you able to add Swift 4 support or when do you plan to do so? Thanks!

[lmcd]

If I can help in any way, let me know. The build errors I'm seeing seem to relate to the use of NSDecimalNumber and lack of conformance to the Numeric protocol.

We could probably resolve these issues by migrating to the Decimal structure, which provides Numeric conformance out of the box.

[danthorpe]

Thanks all, working on Swift 4 now.

[uzumakilord]

@danthorpe Do you solve this problem with the numeric protocol? Where can I find it? I need to migrate a project. Thanks!

[attheodo]

@danthorpe any ETA on when a new version with Swift3.2/4-XCode9.0 will be out? We've kinda reach the point where Money is breaking our build now :(

[danthorpe]

@attheodo I have most of it done, will have a workable branch published tonight which will unblock you. But probably won't have a new version in CocoaPods until Sunday.

[attheodo]

@danthorpe thanks man. That will help a bunch!

[lmcd]

Thanks @danthorpe

[clintonmedbery]

Thanks @danthorpe!
https://media.giphy.com/media/3oKHWikxKFJhjArSXm/giphy.gif

[danthorpe]

I've published the branch: feature/MNY-79_updates_for_xcode_9 which should hopefully unblock everyone from adopting Xcode 9. See: #84

The primary thing which is missing at the moment is full support for localised formatting, ran out of time today, will do this on Sunday. This will get released as a major version 3 as soon as possible. Please chime in on #84 with comments of breaking changes or things which you need.

[OnurVar]

Any updates ?

[sashakid]

feature/MNY-79_updates_for_xcode_9

How to perform arithmetic operations in this branch? Dividing is not working anymore:

let sum = Money(floatLiteral: sum)
return "\(sum.dividing(by: PriceService.shared.price).decimal)"

Value of type 'Money' has no member 'dividing'

[clintonmedbery]

Is this dead now? Haven't seen any updates despite there being progress made.

[clintonmedbery]

RIP

[Ewg777]

@danthorpe any updates?

[namchuai]

well, here we are..

[marbetschar]

@danthorpe .... anything?

Your Money library looks awesome and it does exactly what I need in my project. But I'm a bit frightened using it, because there is a lot of silence around it for the last year or so. So it seems like it is dead - and coding my own solution, and therefore ignore all of your achievements simply feels not right.

That said, I'll happily provide help in coding to bring this awesome library back to life. So let's start rolling with Swift 4 support!

Where to start best?

[marbetschar]

@danthorpe I've found that the branch feature/MNY-79_updates_for_xcode_9 is working quite well in Swift v4.

Based upon that, I've created a pull request for FX which adds support for Swift v4, and another one which adds missing functionality in Money to work properly with the new FX.

Based upon this, it would be awesome to create new releases for both frameworks and take the next steps from there.

Any chance we can get that done somewhen soon?