Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add container exec to cyclops UI #527

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add container exec to cyclops UI #527

wants to merge 2 commits into from

Conversation

pravintargaryen
Copy link

closes #522

📑 Description

Created a new ExecModal component and added a button for exec in the PodTable

✅ Checks

  • I have updated the documentation as required
  • I have performed a self-review of my code

ℹ Additional context

@pravintargaryen pravintargaryen requested a review from a team as a code owner August 25, 2024 14:18
petar-cvit
petar-cvit requested changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the backend part of the implementation

@pravintargaryen
Copy link
Author

Thank you for the feedback. I realize I missed the backend part of the implementation. I'll add the necessary code and update the PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petar-cvit petar-cvit petar-cvit requested changes

Assignees

@pravintargaryen pravintargaryen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add container exec to cyclops UI
2 participants
@pravintargaryen @petar-cvit