From 3762cbe9a6c49091749b07778a6a2d5e5ef07c56 Mon Sep 17 00:00:00 2001 From: Roger Peppe Date: Fri, 2 Feb 2024 10:59:20 +0000 Subject: [PATCH] cmd/cueckoo: fix change ID pattern MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Without the parens around the pattern, this will match any git commit that starts with 4 decimal digits. I suspect that wasn't the intention. Signed-off-by: Roger Peppe Change-Id: Id270f9a1a050dd7d63122ae7dcd96db926d1f1f5 Reviewed-on: https://review.gerrithub.io/c/cue-sh/tools/+/1176396 TryBot-Result: CUEcueckoo Reviewed-by: Daniel Martí --- cmd/cueckoo/cmd/cltrigger.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/cueckoo/cmd/cltrigger.go b/cmd/cueckoo/cmd/cltrigger.go index 8b8e0cb..15cd7df 100644 --- a/cmd/cueckoo/cmd/cltrigger.go +++ b/cmd/cueckoo/cmd/cltrigger.go @@ -51,7 +51,7 @@ func newCLTrigger(cmd *Command, cfg *config, b builder) *cltrigger { // We only really care about CL numbers and Change-ID identifiers from git commit trailers, // since those are what a human user is most likely going to find useful. // The long forms, like "project~branch~I1234..." are far too cumbersome. -var rxChangeID = regexp.MustCompile(`^[1-9][0-9]{3,}|I[0-9a-f]{40}$`) +var rxChangeID = regexp.MustCompile(`^([1-9][0-9]{3,}|I[0-9a-f]{40})$`) func (c *cltrigger) run() (err error) { var changeIDs []revision