Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on post-tournament table window after laptop close #1454

Open
ctm opened this issue Jun 30, 2024 · 3 comments
Open

Panic on post-tournament table window after laptop close #1454

ctm opened this issue Jun 30, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@ctm
Copy link
Owner

ctm commented Jun 30, 2024

Figure out what caused my table window to panic after yesterday's WSOPS tournament.

This morning, when I opened my laptop, the table that I had been playing on had died due to a panic and I foolishly reloaded the page before thinking to look at the JavaScript console. So, I don't know what happened there, but with luck it'll be reproducible.

After yesterday's game, I left the table window up and didn't do a deploy, because there were no updated crates. That's fairly rare and > 90% of the time I do a deploy shortly after the tournament finishes. Additionally, I closed my laptop because I didn't want to be tempted to check on WSER in the middle of the night. So, I'm hoping that I can reproduce this, in which case it'll be trivial to fix.

@ctm ctm added bug Something isn't working high priority Should be done fairly soon easy Trivial to do (even when tired!) and semi-worthwhile labels Jun 30, 2024
@ctm ctm self-assigned this Jun 30, 2024
@ctm ctm changed the title Panic on post-tournamen table window after laptop close Panic on post-tournament table window after laptop close Jun 30, 2024
@ctm
Copy link
Owner Author

ctm commented Jul 1, 2024

I was not able to reproduce this on my own this morning, but I plan on leaving my window open after I bust and then closing my laptop. I normally do a deploy after the evening game if any crates change, and I even said I'd do a deploy of my Ping fix (#1453), but if I remember, I'll not deploy this evening in hopes of reproducing this bug tomorrow morning.

@ctm ctm removed the easy Trivial to do (even when tired!) and semi-worthwhile label Jul 1, 2024
@ctm
Copy link
Owner Author

ctm commented Jul 1, 2024

This one is going to be a PITA to track down, however, I can change various code to not panic but to continue when surprising things happen. I can only do that safely if there's something in place that will prevent infinite (or exceedingly frequent) errors, because for all its warts a panic does prevent that.

So, once I have something in place that rate-limits warnings and errors, I may as well send that info to the server (#1455), then I can replace code that might panic with code that will attempt to report an error and continue, confident (or at least very hopeful) that a cascade of errors won't make things worse.

@ctm ctm removed the high priority Should be done fairly soon label Jul 4, 2024
@ctm
Copy link
Owner Author

ctm commented Jul 4, 2024

Important, in theory, but it's not important enough to look at before BARGE. Unfortunately, tracking down the various ping issues (#1453) ate a bunch of my time and now it's already Independence Day, so I need to be pretty careful with my time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant