Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boards are not sorted properly #743

Open
HeinHuijskes opened this issue Apr 19, 2023 · 3 comments
Open

Boards are not sorted properly #743

HeinHuijskes opened this issue Apr 19, 2023 · 3 comments

Comments

@HeinHuijskes
Copy link
Contributor

HeinHuijskes commented Apr 19, 2023

Sorting of groups on display is done alphabetically, which is nice (and not just because of the name).

For boards however this means that the roman numeral board names sort incorrectly, e.g. "XLe bestuur" (40th board) sorts above "XLIIIe bestuur" (43rd board) due to "e" sorting above "I" semantically.

Since this appears to be a format that is going to stick around for a while, I believe we should override the default and sort it properly.

@HeinHuijskes
Copy link
Contributor Author

HeinHuijskes commented Apr 19, 2023

On a side note: SB is currently sorted first, which is debatable in it's own way, but is probably a completely different discussion since there are no "old" SB boards and they might end up too far down when sorting on roman numerals. Perhaps move them to a new category? This may be overkill, and should have it's own issue and probably be discussed with board if considered.

Also I clearly don't know what I am talking about yet, so please correct me where I am assuming wrong :)

@wilco375
Copy link
Contributor

wilco375 commented Apr 23, 2023

I think SB being at the top is fine but it would be nice to have the boards sorted properly. Not sure what the best approach to this would be though to properly sort the boards but not affect other sorting.

@DrumsnChocolate
Copy link
Contributor

DrumsnChocolate commented Sep 9, 2023

We could define a sort_by attribute on a group_kind model? That would allow for choosing between group.<creation_date_attribute> or group.name
(not sure what the name of the attribute is for the creation date, or where that is in the database but I bet it exists)

But that would require us to introduce a new model, just for this functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants