New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature-request]: Merkle trie properties #24

Open

bsamuels453 opened this issue Apr 17, 2023 · 2 comments

Contributor

bsamuels453 commented Apr 17, 2023

Describe the desired feature or improvement

How challenging would it be to create a generic set of merkle trie properties?
Do merkle trie library interfaces have enough commonalities for this kind of test suite to be possible?

Contributor Author

bsamuels453 commented Jun 14, 2023

Constructs that could be tested:

Merkle Mountain Ranges
Merkle Multi-proofs
Normal Merkle proofs

Contributor Author

bsamuels453 commented Jun 20, 2023

property ideas:

Given a trie T and items to be added X and Y,
a. assert root(T.add(x)) != root(T.add(y))
b. assert root(T.add(x).add(y)) == root(T.add(y).add(x))
c. assert root(T.add(x).add(x)) == root(T.add(x)) (or reverts)
something to check that the value being proved is a leaf and not an intermediate node (I don't think this applies to merkle-patricia tries)
everything from the guidance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment