Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: NeedsReexecution returns same version to execute again in same executor #12

Closed
mmsqe opened this issue Sep 4, 2024 · 4 comments

Comments

@mmsqe
Copy link
Collaborator

mmsqe commented Sep 4, 2024

duplicate version in the log

mm-Run[5][2024-09-04 01:40:14.356035259 +0000 UTC m=+17.847698343]-TryExecute-bf:[707]
mm-Run[10][2024-09-04 01:40:14.356612009 +0000 UTC m=+17.848275093]-TryExecute-bf:[707]
mm-Run[2][2024-09-04 01:40:14.3666073 +0000 UTC m=+17.858270384]-TryExecute-bf:[707]
mm-Run[0][2024-09-04 01:40:14.368322467 +0000 UTC m=+17.859985551]-TryExecute-bf:[707]
mm-Run[7][2024-09-04 01:40:14.3707793 +0000 UTC m=+17.862442468]-TryExecute-bf:[707]
mm-Run[9][2024-09-04 01:40:14.372549592 +0000 UTC m=+17.864212843]-TryExecute-bf:[707]
mm-Run[5][2024-09-04 01:40:14.394555425 +0000 UTC m=+17.886218551]-TryExecute-bf:[707]
mm-Run[7][2024-09-04 01:40:14.4144843 +0000 UTC m=+17.906147426]-TryExecute-bf:[707]
@yihuang
Copy link
Collaborator

yihuang commented Sep 4, 2024

the same tx can be validated multiple times, especially where heavy conflicted, do you have new idea to reduce this overhead?

@mmsqe
Copy link
Collaborator Author

mmsqe commented Sep 4, 2024

the same tx can be validated multiple times, especially where heavy conflicted, do you have new idea to reduce this overhead?

if no way to avoid, we can only reduce the chance of conflict, the top 3 tps for 38 accounts and 100 txs vs 3800 accounts and 1 txs:

[941.1205882891527, 885.1116716884503, 874.6625605441913]
vs
[2493.4573895171425, 1855.615819290917, 1125.6221859445352]

@yihuang
Copy link
Collaborator

yihuang commented Sep 4, 2024

the same tx can be validated multiple times, especially where heavy conflicted, do you have new idea to reduce this overhead?

if no way to avoid, we can only reduce the chance of conflict, the top 3 tps for 38 accounts and 100 txs vs 3800 accounts and 1 txs:


[941.1205882891527, 885.1116716884503, 874.6625605441913]

vs

[2493.4573895171425, 1855.615819290917, 1125.6221859445352]

Add some test cases?

@mmsqe
Copy link
Collaborator Author

mmsqe commented Sep 9, 2024

Add some test cases?

The change is in sdk actually, I tried run benmark test outside.

@mmsqe mmsqe closed this as completed Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants