Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: no minimum packet timeout check for send-tx to host chain on behalf of ica account #1070

Open
mmsqe opened this issue Jul 25, 2024 · 4 comments

Comments

@mmsqe
Copy link
Contributor

mmsqe commented Jul 25, 2024

we need a minimum value for the relative timeout of send-tx in ica controller after migrate to ibc 8.3.x and remove icaauth module in #1068.

@yihuang
Copy link
Collaborator

yihuang commented Jul 25, 2024

the timeout is set by user right? what is the consequence of too low?

@mmsqe
Copy link
Contributor Author

mmsqe commented Jul 25, 2024

yes, but msg server still ensure this min timeout is appropriate before.

@yihuang
Copy link
Collaborator

yihuang commented Jul 25, 2024

yes, but msg server still ensure this min timeout is appropriate before.

I mean why do we need it, what's the consequence without it.

@mmsqe
Copy link
Contributor Author

mmsqe commented Jul 25, 2024

I guess low timeout make it easier to trigger close for ordered channel, but I'm not sure about the history reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants